Bug 37615 - Clean up the form for sending cardnumbers from a report to batch patron modification
Summary: Clean up the form for sending cardnumbers from a report to batch patron modif...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Phil Ringnalda
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on: 37197
Blocks:
  Show dependency treegraph
 
Reported: 2024-08-09 21:13 UTC by Phil Ringnalda
Modified: 2024-08-17 09:38 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This tidies up the form used when initiating patron batch modifications from a report that uses card numbers (option for 'Batch operations with X visible records'). There is no visible difference (the form that sends the card numbers to the patron batch modification form now puts them in a single text area, instead of multiple inputs).
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification (2.94 KB, patch)
2024-08-15 22:18 UTC, Phil Ringnalda
Details | Diff | Splinter Review
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification (2.99 KB, patch)
2024-08-16 03:17 UTC, David Nind
Details | Diff | Splinter Review
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification (3.08 KB, patch)
2024-08-16 09:17 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Phil Ringnalda 2024-08-09 21:13:27 UTC
Followup to bug 37197, because I wrote the patch there based on reverting the changes from the wrong CSRF patch - https://git.koha-community.org/Koha-community/Koha/commit/8a20e0cb6a0efd6b993e361d439dbb4486ba15d1 changed it from a POST to cud-show into a GET of show, but then later on https://git.koha-community.org/Koha-community/Koha/commit/21fa3f64c31dad23e50e633a6f51f98c8f7ade12 tried to make that actually work by switching from a textarea to a (long) list of inputs, which isn't needed now that we've gone back to a POST. It should just be a textarea like the other POSTed lists of numbers.
Comment 1 Phil Ringnalda 2024-08-15 22:18:39 UTC
Created attachment 170413 [details] [review]
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification

Since bug 37197 switched reports back to using a POST to send cardnumbers to
batch modification, we should also be using a single textarea rather than
multiple inputs.

Test plan:
1. Reports - Create from SQL - give it a name, and the SQL
   select cardnumber from borrowers limit 3
2. Save report - Run report
3. Batch operations with 3 visible records - Batch patron modification
4. Verify that you have the same three cardnumbers in Batch patron modification
   as were in the report.
Comment 2 David Nind 2024-08-16 03:17:23 UTC
Created attachment 170420 [details] [review]
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification

Since bug 37197 switched reports back to using a POST to send cardnumbers to
batch modification, we should also be using a single textarea rather than
multiple inputs.

Test plan:
1. Reports - Create from SQL - give it a name, and the SQL
   select cardnumber from borrowers limit 3
2. Save report - Run report
3. Batch operations with 3 visible records - Batch patron modification
4. Verify that you have the same three cardnumbers in Batch patron modification
   as were in the report.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-08-16 03:22:51 UTC
I have signed off.

However, I noticed no visible difference before and after the patch was applied - and everything worked as expected, both before and after.

Could you explain what is actually changing here - I don't see a text area, so the patch description does not make any sense to me.

If there is nothing visible that changes when testing and that everything should work as expected (both before and after the patch), it would be useful to say that (for us mere mortals that don't necessarily understand developer speak!).
Comment 4 Phil Ringnalda 2024-08-16 03:29:53 UTC
If you want to see the difference, you can view source on the report results page, and search for modborrowers.pl - before you'll see three <input>s, after you'll see one <textarea>.
Comment 5 Marcel de Rooy 2024-08-16 09:17:05 UTC
Created attachment 170447 [details] [review]
Bug 37615: Clean up the form for sending cardnumbers from a report to batch patron modification

Since bug 37197 switched reports back to using a POST to send cardnumbers to
batch modification, we should also be using a single textarea rather than
multiple inputs.

Test plan:
1. Reports - Create from SQL - give it a name, and the SQL
   select cardnumber from borrowers limit 3
2. Save report - Run report
3. Batch operations with 3 visible records - Batch patron modification
4. Verify that you have the same three cardnumbers in Batch patron modification
   as were in the report.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Comment 6 Katrin Fischer 2024-08-16 15:37:48 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 7 David Nind 2024-08-17 09:38:07 UTC
(In reply to Phil Ringnalda from comment #4)
> If you want to see the difference, you can view source on the report results
> page, and search for modborrowers.pl - before you'll see three <input>s,
> after you'll see one <textarea>.

Thanks for explaining!