Attachment 170573 Details for Bug 37701 – Bug 37701: Remove object_type from viewlog

[patch] Bug 37701: Remove object_type from viewlog

Bug-37701-Remove-objecttype-from-viewlog.patch (text/plain), 2.83 KB, created by Lucas Gass (lukeg) on 2024-08-21 17:38:13 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-08-21 17:38:13 UTC

Size: 2.83 KB

patch

obsolete

>From 7395915df0134f8ef339357cdea7f9f8a6b718a3 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 21 Aug 2024 17:34:43 +0000
>Subject: [PATCH] Bug 37701: Remove object_type from viewlog
>
>To test:
>1. Find a record and do 1 edit to the record.
>2. Also do 1 edit to an item on that record.
>3. From the navbar on the left click 'Modification log'
>4. You should see both the item and record modifications in log.
>5. Notice also that the 'Catalog' module checkbox is checked by default
>6. Now check 'All' instead and click 'Submit'
>7. Now the item modification is gone, you only see the record modification.
>8. APPLY PATCH and restart_all
>9. Try again, you should now always see item information when viewing the log.
>10. Test the log viewer from the link in on the record detail page.
>11. Also test by going directly to the Log viewer tool. ( Tools > Log viewer)
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +-
> tools/viewlog.pl                                              | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>index 3e5625eff0..86e2244c0c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>@@ -110,7 +110,7 @@
>         [%- ELSE -%]
>         <li>
>         [%- END -%]
>-            <a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblio_object_id | url  %]&amp;object_type=biblio">Modification log</a>
>+            <a href="/cgi-bin/koha/tools/viewlog.pl?do_it=1&amp;modules=CATALOGUING&amp;action=MODIFY&amp;object=[% biblio_object_id | url  %]">Modification log</a>
>         </li>
>         [%- END -%]
> 
>diff --git a/tools/viewlog.pl b/tools/viewlog.pl
>index 91cd65df25..0312dbf122 100755
>--- a/tools/viewlog.pl
>+++ b/tools/viewlog.pl
>@@ -50,7 +50,6 @@ my $user     = $input->param("user") // '';
> my @actions  = $input->multi_param("actions");
> my @interfaces  = $input->multi_param("interfaces");
> my $object   = $input->param("object");
>-my $object_type = $input->param("object_type") // '';
> my $info     = $input->param("info");
> my $datefrom = $input->param("from");
> my $dateto   = $input->param("to");
>@@ -128,7 +127,7 @@ if ($do_it) {
>     $search_params{action} = { -in => [ @actions ] } if ( defined $actions[0] && $actions[0] ne '' );
>     $search_params{interface} = { -in => [ @interfaces ] } if ( defined $interfaces[0] && $interfaces[0] ne '' );
> 
>-    if ( @modules == 1 && $object_type eq 'biblio' ) {
>+    if ( @modules == 1 ) {
>         # Handle 'Modification log' from cataloguing
>         my $biblio = Koha::Biblios->find( $object );
>         my @itemnumbers = $biblio->items->get_column('itemnumber');
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37701: 170573 | 170574