To recreate: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification.
In viewlog.pl there is 'object_type'. It is only passed when you come to the log viewer from the record link. I think it may be unnessesary? Without it you are not able to get item level info. related to the bib when you come to the log viewer in any other way than directly for the 'Modification log' link on the record detail page.
Created attachment 170573 [details] [review] Bug 37701: Remove object_type from viewlog To test: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification. 8. APPLY PATCH and restart_all 9. Try again, you should now always see item information when viewing the log. 10. Test the log viewer from the link in on the record detail page. 11. Also test by going directly to the Log viewer tool. ( Tools > Log viewer)
Created attachment 170574 [details] [review] Bug 37701: Remove object_type from viewlog To test: 1. Find a record and do 1 edit to the record. 2. Also do 1 edit to an item on that record. 3. From the navbar on the left click 'Modification log' 4. You should see both the item and record modifications in log. 5. Notice also that the 'Catalog' module checkbox is checked by default 6. Now check 'All' instead and click 'Submit' 7. Now the item modification is gone, you only see the record modification. 8. APPLY PATCH and restart_all 9. Try again, you should now always see item information when viewing the log. 10. Test the log viewer from the link in on the record detail page. 11. Also test by going directly to the Log viewer tool. ( Tools > Log viewer) Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Taking a look here
This causes the following error when running a "All" report without object on the URL: Can't call method "items" on an undefined value at /kohadevbox/koha/tools/viewlog.pl line 138 To reproduce: 1) Apply patch 2) Run a normal "All" report" from: http://localhost:8081/cgi-bin/koha/tools/viewlog.pl The line may or may not need to be: if ( @modules == 1 && $modules[0] eq 'CATALOGUING' ) { From: https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=10352&attachment=97148
The initial patch on bug 10352 had that line, but then it was changed to use the object_type parameter so that there was a way to differentiate between searching for a bib record (and all attached items), and searching for a specific item, when there's overlap between the biblionumbers in the system and the itemnumbers in the system - https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352#c12 Could we go the opposite direction and expose the object_type paramater in the UI instead? Maybe a checkbox next to the object field, something like, "Search for biblio object and all attached items"?
Oops, sorry for the accidental status change!