Attachment 171071 Details for Bug 37311 – Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

[patch] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Bug-37311-follow-up-Use-Bootstrap-badge-classes-fo.patch (text/plain), 2.63 KB, created by Owen Leonard on 2024-09-05 13:09:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Owen Leonard

Created: 2024-09-05 13:09:07 UTC

Size: 2.63 KB

patch

obsolete

>From 570d651f5c23198bdb47cabb9441c44245c7deeb Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Thu, 5 Sep 2024 12:57:57 +0000
>Subject: [PATCH] Bug 37311: (follow-up) Use Bootstrap badge classes for some
> statuses
>
>Rather than add a style to a whole table row I think we should use BS5's
>badge classes to style debug mode and default configuration information.
>
>To test you should have at least one SMTP server set as default and at
>least one with debug mode turned on.
>
>Go to Administration -> SMTP servers and view the table of SMTP servers.
>Any server with debug mode turned on should show "On" styled as a yellow
>badge with black text. A server set as default should show "Default"
>styled as a green badge with white text.
>---
> .../prog/en/modules/admin/smtp_servers.tt          | 14 ++++----------
> 1 file changed, 4 insertions(+), 10 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>index 871c709de0..77226367ac 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt
>@@ -402,7 +402,8 @@
>                     {
>                         "data": function( row, type, val, meta ) {
>                             if ( row.debug ) {
>-                                return _("On");
>+                                let result = '<span class="badge text-bg-warning">' + _("On") + '</span>';
>+                                return result;
>                             }
>                             else {
>                                 return _("");
>@@ -414,7 +415,8 @@
>                     {
>                         "data": function( row, type, val, meta ) {
>                             if ( row.is_default ) {
>-                                return _("Default");
>+                                let result = '<span class="badge text-bg-success">' + _("Default") + '</span>';
>+                                return result;
>                             } else {
>                                 return "";
>                             }
>@@ -432,14 +434,6 @@
>                         "orderable": false
>                     }
>                 ],
>-                createdRow: function (row, data, dataIndex) {
>-                    if ( data.is_default ) {
>-                        $(row).addClass('default');
>-                    }
>-                    if ( data.debug ) {
>-                        $(row).addClass('debug');
>-                    }
>-                },
>             });
> 
>             $('#smtp_servers').on( "click", '.delete_server', function () {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37311: 168762 | 168774 | 171070 | 171071 | 171148 | 171149