Bug 37311 - Tone down the SMTP servers administration page
Summary: Tone down the SMTP servers administration page
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-10 18:01 UTC by Owen Leonard
Modified: 2024-09-06 19:20 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37311: Tone down the SMTP servers administration page (5.59 KB, patch)
2024-07-10 18:26 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37311: Tone down the SMTP servers administration page (5.64 KB, patch)
2024-07-11 04:28 UTC, David Nind
Details | Diff | Splinter Review
Bug 37311: Tone down the SMTP servers administration page (5.64 KB, patch)
2024-09-05 13:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses (2.63 KB, patch)
2024-09-05 13:09 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses (2.68 KB, patch)
2024-09-06 19:05 UTC, Olivier V
Details | Diff | Splinter Review
Bug 37311: Tone down the SMTP servers administration page (5.69 KB, patch)
2024-09-06 19:20 UTC, Olivier V
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Owen Leonard 2024-07-10 18:01:36 UTC
Information about the current configuration is shown as an informational dialog, and default server and debugging status are highlighted in red as if it were an error needing attention. I think the page could be restyled to convey the information without the implicit demand for action.
Comment 1 Owen Leonard 2024-07-10 18:26:16 UTC
Created attachment 168762 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Comment 2 David Nind 2024-07-11 04:28:32 UTC
Created attachment 168774 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Katrin Fischer 2024-09-02 09:42:21 UTC
I don't want to miss something, please rebase!
Comment 4 Owen Leonard 2024-09-05 13:09:05 UTC
Created attachment 171070 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Comment 5 Owen Leonard 2024-09-05 13:09:07 UTC
Created attachment 171071 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.
Comment 6 Olivier V 2024-09-06 19:05:34 UTC
Created attachment 171148 [details] [review]
Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses

Rather than add a style to a whole table row I think we should use BS5's
badge classes to style debug mode and default configuration information.

To test you should have at least one SMTP server set as default and at
least one with debug mode turned on.

Go to Administration -> SMTP servers and view the table of SMTP servers.
Any server with debug mode turned on should show "On" styled as a yellow
badge with black text. A server set as default should show "Default"
styled as a green badge with white text.

Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 7 Olivier V 2024-09-06 19:20:13 UTC
Created attachment 171149 [details] [review]
Bug 37311: Tone down the SMTP servers administration page

This patch makes some structural and style changes to the SMTP servers
page to show information in a way that doesn't imply that the user has
to take action on it.

I also added an "Edit" link to the "current default configuration"
information section so that users wouldn't have to search through the
list of servers to find the right edit link..

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface)

- Go to Administration -> SMTP servers.
- If necessary, add multiple SMTP servers:
  - One in debug mode
  - One which isn't in debug mode
  - One which is the default
- Confirm that the list of SMTP servers looks good and that it's still
  easy to tell which servers are in debug mode and which is the default.
  - Confirm that the new "Edit" link in that area works correctly.
- Confirm that the display of the current default configuration looks
  good.
  - Test how this information looks when editing an existing server.

Sponsored-by: Athens County Public Libraries
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>