Information about the current configuration is shown as an informational dialog, and default server and debugging status are highlighted in red as if it were an error needing attention. I think the page could be restyled to convey the information without the implicit demand for action.
Created attachment 168762 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries
Created attachment 168774 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
I don't want to miss something, please rebase!
Created attachment 171070 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com>
Created attachment 171071 [details] [review] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text.
Created attachment 171148 [details] [review] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 171149 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Sorry patch doesn't apply due to ye old fake ancestor: Applying: Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/smtp_servers.tt). error: could not build fake ancestor Patch failed at 0001 Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses
Created attachment 174473 [details] [review] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 174474 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 174475 [details] [review] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Created attachment 174938 [details] [review] Bug 37311: Tone down the SMTP servers administration page This patch makes some structural and style changes to the SMTP servers page to show information in a way that doesn't imply that the user has to take action on it. I also added an "Edit" link to the "current default configuration" information section so that users wouldn't have to search through the list of servers to find the right edit link.. To test, apply the patch and rebuild the staff interface CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface) - Go to Administration -> SMTP servers. - If necessary, add multiple SMTP servers: - One in debug mode - One which isn't in debug mode - One which is the default - Confirm that the list of SMTP servers looks good and that it's still easy to tell which servers are in debug mode and which is the default. - Confirm that the new "Edit" link in that area works correctly. - Confirm that the display of the current default configuration looks good. - Test how this information looks when editing an existing server. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Created attachment 174939 [details] [review] Bug 37311: (follow-up) Use Bootstrap badge classes for some statuses Rather than add a style to a whole table row I think we should use BS5's badge classes to style debug mode and default configuration information. To test you should have at least one SMTP server set as default and at least one with debug mode turned on. Go to Administration -> SMTP servers and view the table of SMTP servers. Any server with debug mode turned on should show "On" styled as a yellow badge with black text. A server set as default should show "Default" styled as a green badge with white text. Signed-off-by: Olivier V <olivier.vezina@inLibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>