Bugzilla – Attachment 171129 Details for
Bug 37818
XXX trick in installer code is not longer needed
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37818: Remove 'XXX' from the installer code
Bug-37818-Remove-XXX-from-the-installer-code.patch (text/plain), 1.04 KB, created by
Julian Maurice
on 2024-09-06 08:25:02 UTC
(
hide
)
Description:
Bug 37818: Remove 'XXX' from the installer code
Filename:
MIME Type:
Creator:
Julian Maurice
Created:
2024-09-06 08:25:02 UTC
Size:
1.04 KB
patch
obsolete
>From e85bdb287a87287850a11c6bb9590c499bc73e26 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 3 Sep 2024 11:43:49 +0200 >Subject: [PATCH] Bug 37818: Remove 'XXX' from the installer code > >We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068). > >We do no longer need this code. > >Signed-off-by: David Nind <david@davidnind.com> >Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> >--- > Koha/Installer.pm | 4 ---- > 1 file changed, 4 deletions(-) > >diff --git a/Koha/Installer.pm b/Koha/Installer.pm >index 48f8fc0f01..235eac3247 100644 >--- a/Koha/Installer.pm >+++ b/Koha/Installer.pm >@@ -55,10 +55,6 @@ sub TransformToNum { > # remove the 3 last . to have a Perl number > $version =~ s/(.*\..*)\.(.*)\.(.*)/$1$2$3/; > >- # three X's at the end indicate that you are testing patch with dbrev >- # change it into 999 >- # prevents error on a < comparison between strings (should be: lt) >- $version =~ s/XXX$/999/; > return $version; > } > >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37818
:
170964
|
170976
| 171129 |
171468