Bug 37818 - XXX trick in installer code is not longer needed
Summary: XXX trick in installer code is not longer needed
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (command-line installer) (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low minor
Assignee: Jonathan Druart
QA Contact: Julian Maurice
URL:
Keywords:
Depends on: 13068
Blocks:
  Show dependency tree / graph
 
Reported: 2024-09-03 09:43 UTC by Jonathan Druart
Modified: 2024-11-18 16:02 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37818: Remove 'XXX' from the installer code (959 bytes, patch)
2024-09-03 09:44 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 37818: Remove 'XXX' from the installer code (1006 bytes, patch)
2024-09-03 10:53 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37818: Remove 'XXX' from the installer code (1.04 KB, patch)
2024-09-06 08:25 UTC, Julian Maurice 		Details | Diff | Splinter Review
Bug 37818: (follow-up) Remove failing XXX tests from Installer.t (917 bytes, patch)
2024-09-13 14:17 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-09-03 09:43:12 UTC 
We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068).

We do no longer need this code.
Comment 1 Jonathan Druart 2024-09-03 09:44:14 UTC 
Created attachment 170964 [details] [review]
Bug 37818: Remove 'XXX' from the installer code

We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068).

We do no longer need this code.
Comment 2 David Nind 2024-09-03 10:53:18 UTC 
Created attachment 170976 [details] [review]
Bug 37818: Remove 'XXX' from the installer code

We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068).

We do no longer need this code.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 David Nind 2024-09-03 10:54:01 UTC 
Testing notes (using KTD):

1. Read the diff for the patch - looks OK to me.
Comment 4 Julian Maurice 2024-09-06 08:25:02 UTC 
Created attachment 171129 [details] [review]
Bug 37818: Remove 'XXX' from the installer code

We were adding "XXX" that was replaced with "999" before the move to the atomic update files (bug 13068).

We do no longer need this code.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Comment 5 Katrin Fischer 2024-09-13 11:58:34 UTC 
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Katrin Fischer 2024-09-13 14:09:48 UTC 
Unfortunately, this broke tests:

# Subtest: get_atomic_updates method
    1..1
    ok 1 - get_atomic_updates returns correct files
ok 4 - get_atomic_updates method

    #   Failed test 'TransformToNum('18.05.02.XXX') = '18.0502999''
    #   at t/db_dependent/Koha/Installer.t line 116.
    #          got: '18.0502XXX'
    #     expected: '18.0502999'

    #   Failed test 'TransformToNum('19.11.02.XXX') = '19.1102999''
    #   at t/db_dependent/Koha/Installer.t line 116.
    #          got: '19.1102XXX'
    #     expected: '19.1102999'
    # Looks like you failed 2 tests of 5.

#   Failed test 'TransformToNum'
#   at t/db_dependent/Koha/Installer.t line 119.

I guess we can just remove these now?
Comment 7 Katrin Fischer 2024-09-13 14:17:40 UTC 
Created attachment 171468 [details] [review]
Bug 37818: (follow-up) Remove failing XXX tests from Installer.t
Comment 8 Katrin Fischer 2024-09-13 14:18:00 UTC 
I've removed the failing XXX related tests and reset the test counter.
Comment 9 Lucas Gass (lukeg) 2024-11-18 16:02:58 UTC 
Doesn't apply clean to 24.05, no backport.