Attachment 171231 Details for Bug 37662 – Bug 37662: Improve library information text consistency

[patch] Bug 37662: Improve library information text consistency

Bug-37662-Improve-library-information-text-consist.patch (text/plain), 7.07 KB, created by Olivier Vezina on 2024-09-09 20:02:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Olivier Vezina

Created: 2024-09-09 20:02:23 UTC

Size: 7.07 KB

patch

obsolete

>From 1cbf0a2449df181db73205186f941c9c86253970 Mon Sep 17 00:00:00 2001
>From: David Nind <david@davidnind.com>
>Date: Fri, 16 Aug 2024 22:05:49 +0000
>Subject: [PATCH] Bug 37662: Improve library information text consistency
>
>This improves the consistency of the text between the staff
>interface library information listing page, and the add,
>view, and modify library pages. It also improves the text
>for some field hints.
>
>Test plan:
>1. Go to Koha administration > Basic parameters > Libraries.
>2. Note these inconsistencies:
>   2.1 Library hours - the text if no hours are set:
>       - For the table, the text is "Library hours not set"
>       - For the view, add, and modify library pages the text
>         is "No opening hours have been set."
>   2.2 The column and field names for library hours:
>       - For the table, the column name in the list of libraries
>         is "Library hours".
>       - For the view, add, and modify library pages the field
>         label is "Opening hours".
>   2.3 For the "MARC organization code" field, there is no
>       colon (:) on the view, add, and modify library pages.
>   2.4 For the "OPAC info" field name, "info" is not spelt
>       in full.
>   2.5 The hints for the Reply-To and Return-Path fields use
>       this format "Default: <SystemPreferenceName> system
>       preference" pattern, but the MARC organization code
>       field doesn't.
>3. Leave tabs open for the library listing, view, and modify
>   library pages.
>4. Apply the patch, then duplicate and refresh the tabs for
>   the library listing, view, and modify library pages (so
>   you can compare the differences).
>5. Note that the inconsistencies in step 2 are now fixed.
>6. Note that the hint text for these fields is changed:
>   6.1 IP field: active voice
>   6.2 MARC organization code: follows the pattern used for
>       the Reply-To and Return-Path fields.
>   6.3 Public: 'yes' to 'Yes'
>7. Sign off D:
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
>---
> .../prog/en/modules/admin/branches.tt         | 22 +++++++++----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>index 5f22297234..09d661f3d6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt
>@@ -241,7 +241,7 @@
>                     </select>
>                 </li>
>                 <li><label for="branchurl">URL: </label><input type="text" name="branchurl" id="branchurl"  size="80" value="[% library.branchurl | html %]" class="url" /></li>
>-                <li><label for="opac_info">OPAC info: </label>
>+                <li><label for="opac_info">OPAC information: </label>
>                     [% IF OpacLibraryInfo %]
>                         <div>[% OpacLibraryInfo.content | $raw %]</div>
>                         <div class="hint"><a href="/cgi-bin/koha/tools/additional-contents.pl?category=html_customizations&op=add_form&id=[% OpacLibraryInfo.id | $raw %]&editmode=wysiwyg" target="_blank">Edit HTML content</a></div>
>@@ -252,19 +252,19 @@
>                 <li>
>                     <label for="branchip">IP: </label>
>                     <input type="text" name="branchip" id="branchip"  size="15" maxlength="15" value="[% library.branchip | html %]" />
>-                    <div class="hint">Can be entered as a single IP, or a subnet such as 192.168.1.*</div>
>+                    <div class="hint">Enter as a single IP address, or a subnet such as 192.168.1.*</div>
>                 </li>
>                 <li>
>-                    <label for="marcorgcode">MARC organization code</label>
>+                    <label for="marcorgcode">MARC organization code: </label>
>                     <input type="text" name="marcorgcode" id="marcorgcode" size="16" maxlength="16" value="[% library.marcorgcode | html %]" />
>                     <div class="hint">
>                         [% IF ( CAN_user_parameters_manage_sysprefs ) %]
>                             [% pref_MARCOrgCode_link = BLOCK %]<a href="/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=MARCOrgCode">MARCOrgCode</a>[% END %]
>-                            If not filled in defaults to system preference [% pref_MARCOrgCode_link | $raw | $KohaSpan %].
>+                            Default: [% pref_MARCOrgCode_link | $raw | $KohaSpan %] system preference.
>                         [% ELSE %]
>-                            If not filled in defaults to system preference MARCOrgCode.
>+                            Default: MARCOrgCode system preference.
>                         [% END %]
>-                        You can obtain your code from <a href="http://www.loc.gov/marc/organizations/orgshome.html" target="_blank">Library of Congress</a>.
>+                        Obtain a library code from the <a href="https://www.loc.gov/marc/organizations/orgshome.html" target="_blank">Library of Congress</a>.
>                     </div>
>                 </li>
>                 <li><label for="branchnotes">Notes: </label><input type="text" name="branchnotes" id="branchnotes" size="80" value="[% library.branchnotes | html %]" /></li>
>@@ -289,10 +289,10 @@
>                         <option value="0" selected="selected">No</option>
>                         [% END %]
>                     </select>
>-                    <div class="hint">Set to 'yes' to show this library as a search option and on the libraries page in the OPAC.</div>
>+                    <div class="hint">Set to 'Yes' to show this library as a search option and on the libraries page in the OPAC.</div>
>                 </li>
>                 <li>
>-                    <label for="library_hours">Opening hours: </label>
>+                    <label for="library_hours">Library hours: </label>
>                     <table id="library_hours_table">
>                         <thead>
>                             <tr>
>@@ -532,7 +532,7 @@
>                         [% library.branchip | html %]
>                     </li>
>                     <li>
>-                        <span class="label">MARC organization code</span>
>+                        <span class="label">MARC organization code:</span>
>                         [% library.marcorgcode | html %]
>                     </li>
>                     <li>
>@@ -556,7 +556,7 @@
>                         [% END %]
>                     </li>
>                     <li>
>-                        <span class="label">Opening hours: </span>
>+                        <span class="label">Library hours: </span>
>                         [% SET CalendarFirstDayOfWeek = Koha.Preference("CalendarFirstDayOfWeek") %]
>                         [% SET set_hours = 0 %]
>                         [% IF library.library_hours.count > 0 %]
>@@ -595,7 +595,7 @@
>                                 </tbody>
>                             </table>
>                         [% ELSE %]
>-                            <span>No opening hours have been set.</span>
>+                            <span>Library hours not set</span>
>                         [% END %]
>                     </li>
>                 </ol>
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37662: 170461 | 171231 | 173542