Bug 37662 - Library information - text inconsistencies between the table, edit form, and display page
Summary: Library information - text inconsistencies between the table, edit form, and ...
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: System Administration (show other bugs)
Version: Main
Hardware: All All
: P5 - low trivial
Assignee: David Nind
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 36594
Blocks:
  Show dependency tree / graph
 
Reported: 2024-08-16 21:28 UTC by David Nind
Modified: 2024-10-29 15:17 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: String patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes some text inconsistencies for the library information listing page, and the add, view and modify library pages. This includes: 1. Using the message "Library hours not set" for the text if no hours are set. 2. Using "Library hours" for the column and field name for library hours. 3. Adding a missing colon (:) for the "MARC organization code" field. 4. Spelling "information" in full for the previously labelled "OPAC info" field. 5. Updating the hint text for the IP, MARC organization code, and Public fields.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 37662: Improve library information text consistency (7.02 KB, patch)
2024-08-16 22:54 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37662: Improve library information text consistency (7.07 KB, patch)
2024-09-09 20:02 UTC, Olivier Vezina 		Details | Diff | Splinter Review
Bug 37662: Improve library information text consistency (7.14 KB, patch)
2024-10-28 14:41 UTC, Martin Renvoize (ashimema) 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Nind 2024-08-16 21:28:02 UTC 
There are some text inconsistencies between the staff interface table listing the library information, the library edit form, and the library display page (Administration > Basic parameters > Libraries):

1. If no library opening and closing times are set, it displays as "Library hours not set" in the library hours column. However, if you view the library details (selecting the library name in the name column), the text is "No opening hours have been set."

2. The column name in the list of libraries is "Library hours". However:
   2.1 If you view the library details (selecting the library name in the name column), the field label is "Opening hours".
   2.2 If you add a library, or edit a library's details, the field label is "Opening hours".

3. The "MARC organization code" field is missing the colon (:) on the library edit form and display page.

4. The "OPAC info" field name should be spelt in full as "OPAC information".

Also, ideally, the address information should be displayed similar to how a patron's address is displayed. That is, as an address block without the individual fields (as it does in the table listing all libraries).
Comment 1 David Nind 2024-08-16 22:54:23 UTC 
Created attachment 170461 [details] [review]
Bug 37662: Improve library information text consistency

This improves the consistency of the text between the staff
interface library information listing page, and the add,
view, and modify library pages. It also improves the text
for some field hints.

Test plan:
1. Go to Koha administration > Basic parameters > Libraries.
2. Note these inconsistencies:
   2.1 Library hours - the text if no hours are set:
       - For the table, the text is "Library hours not set"
       - For the view, add, and modify library pages the text
         is "No opening hours have been set."
   2.2 The column and field names for library hours:
       - For the table, the column name in the list of libraries
         is "Library hours".
       - For the view, add, and modify library pages the field
         label is "Opening hours".
   2.3 For the "MARC organization code" field, there is no
       colon (:) on the view, add, and modify library pages.
   2.4 For the "OPAC info" field name, "info" is not spelt
       in full.
   2.5 The hints for the Reply-To and Return-Path fields use
       this format "Default: <SystemPreferenceName> system
       preference" pattern, but the MARC organization code
       field doesn't.
3. Leave tabs open for the library listing, view, and modify
   library pages.
4. Apply the patch, then duplicate and refresh the tabs for
   the library listing, view, and modify library pages (so
   you can compare the differences).
5. Note that the inconsistencies in step 2 are now fixed.
6. Note that the hint text for these fields is changed:
   6.1 IP field: active voice
   6.2 MARC organization code: follows the pattern used for
       the Reply-To and Return-Path fields.
   6.3 Public: 'yes' to 'Yes'
7. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Comment 2 Olivier Vezina 2024-09-09 20:02:23 UTC 
Created attachment 171231 [details] [review]
Bug 37662: Improve library information text consistency

This improves the consistency of the text between the staff
interface library information listing page, and the add,
view, and modify library pages. It also improves the text
for some field hints.

Test plan:
1. Go to Koha administration > Basic parameters > Libraries.
2. Note these inconsistencies:
   2.1 Library hours - the text if no hours are set:
       - For the table, the text is "Library hours not set"
       - For the view, add, and modify library pages the text
         is "No opening hours have been set."
   2.2 The column and field names for library hours:
       - For the table, the column name in the list of libraries
         is "Library hours".
       - For the view, add, and modify library pages the field
         label is "Opening hours".
   2.3 For the "MARC organization code" field, there is no
       colon (:) on the view, add, and modify library pages.
   2.4 For the "OPAC info" field name, "info" is not spelt
       in full.
   2.5 The hints for the Reply-To and Return-Path fields use
       this format "Default: <SystemPreferenceName> system
       preference" pattern, but the MARC organization code
       field doesn't.
3. Leave tabs open for the library listing, view, and modify
   library pages.
4. Apply the patch, then duplicate and refresh the tabs for
   the library listing, view, and modify library pages (so
   you can compare the differences).
5. Note that the inconsistencies in step 2 are now fixed.
6. Note that the hint text for these fields is changed:
   6.1 IP field: active voice
   6.2 MARC organization code: follows the pattern used for
       the Reply-To and Return-Path fields.
   6.3 Public: 'yes' to 'Yes'
7. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier V <olivier.vezina@inLibro.com>
Comment 3 David Nind 2024-09-09 20:06:27 UTC 
Thanks for the sign off Olivier V!
Comment 4 Martin Renvoize (ashimema) 2024-10-28 14:41:17 UTC 
Created attachment 173542 [details] [review]
Bug 37662: Improve library information text consistency

This improves the consistency of the text between the staff
interface library information listing page, and the add,
view, and modify library pages. It also improves the text
for some field hints.

Test plan:
1. Go to Koha administration > Basic parameters > Libraries.
2. Note these inconsistencies:
   2.1 Library hours - the text if no hours are set:
       - For the table, the text is "Library hours not set"
       - For the view, add, and modify library pages the text
         is "No opening hours have been set."
   2.2 The column and field names for library hours:
       - For the table, the column name in the list of libraries
         is "Library hours".
       - For the view, add, and modify library pages the field
         label is "Opening hours".
   2.3 For the "MARC organization code" field, there is no
       colon (:) on the view, add, and modify library pages.
   2.4 For the "OPAC info" field name, "info" is not spelt
       in full.
   2.5 The hints for the Reply-To and Return-Path fields use
       this format "Default: <SystemPreferenceName> system
       preference" pattern, but the MARC organization code
       field doesn't.
3. Leave tabs open for the library listing, view, and modify
   library pages.
4. Apply the patch, then duplicate and refresh the tabs for
   the library listing, view, and modify library pages (so
   you can compare the differences).
5. Note that the inconsistencies in step 2 are now fixed.
6. Note that the hint text for these fields is changed:
   6.1 IP field: active voice
   6.2 MARC organization code: follows the pattern used for
       the Reply-To and Return-Path fields.
   6.3 Public: 'yes' to 'Yes'
7. Sign off D:

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Olivier Vezina <olivier.vezina@inLibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-10-29 15:17:59 UTC 
Pushed for 24.11!

Well done everyone, thank you!