Attachment 171306 Details for Bug 37859 – Bug 37859: Fix style of tabs on comment review page

[patch] Bug 37859: Fix style of tabs on comment review page

Bug-37859-Fix-style-of-tabs-on-comment-review-page.patch (text/plain), 3.10 KB, created by Jonathan Druart on 2024-09-11 13:02:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2024-09-11 13:02:46 UTC

Size: 3.10 KB

patch

obsolete

>From 1e3f1a94b52d555de65640aa88c24b541290c743 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Mon, 9 Sep 2024 11:45:17 +0000
>Subject: [PATCH] Bug 37859: Fix style of tabs on comment review page
>
>This patch corrects the tab markup on the comment review page. These
>tabs are just links styled as tabs -- there isn't any JS tab swapping.
>This kind of "static" tab markup wasn't handled by the tabs WRAPPER
>work.
>
>To test you should have some comments data in your system:
>
> - Go to Administration -> System preferences and enable the
>   "OPACComments" preference.
> - Log in to the OPAC and search for a bibliographic record.
> - View the detail page for the record and click the "Comments" tab.
> - Click "Post your comments on this title."
> - Enter some text in the review box and submit.
>
>In the staff interface, go to Tools -> Comments.
>
> - You should see two tabs: "Approved comments" and "Comments awaiting
>   moderation."
> - Confirm that the tabs look correct.
> - Approve one or more comments and confirm that the tabs work correctly
>   to switch views.
>
>Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../prog/en/modules/reviews/reviewswaiting.tt | 24 +++++++++----------
> 1 file changed, 12 insertions(+), 12 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reviews/reviewswaiting.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reviews/reviewswaiting.tt
>index 9892df26f69..1a2ea563fca 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reviews/reviewswaiting.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reviews/reviewswaiting.tt
>@@ -51,19 +51,19 @@
> 
> <div class="toptabs">
>     <ul class="nav nav-tabs" role="tablist">
>-        [% IF ( status ) %]
>-            <li role="presentation" class="active">
>-        [% ELSE %]
>-            <li role="presentation">
>-        [% END %]
>-            <a href="/cgi-bin/koha/reviews/reviewswaiting.pl?status=1">Approved comments</a>
>+        <li role="presentation" class="nav-item">
>+            [% IF ( status ) %]
>+                <a class="nav-link active" href="/cgi-bin/koha/reviews/reviewswaiting.pl?status=1">Approved comments</a>
>+            [% ELSE %]
>+                <a class="nav-link" href="/cgi-bin/koha/reviews/reviewswaiting.pl?status=1">Approved comments</a>
>+            [% END %]
>         </li>
>-        [% IF ( status ) %]
>-            <li role="presentation">
>-        [% ELSE %]
>-            <li role="presentation" class="active">
>-        [% END %]
>-            <a href="/cgi-bin/koha/reviews/reviewswaiting.pl" >Comments awaiting moderation</a>
>+        <li role="presentation" class="nav-item">
>+            [% IF ( status ) %]
>+                <a class="nav-link" href="/cgi-bin/koha/reviews/reviewswaiting.pl" >Comments awaiting moderation</a>
>+            [% ELSE %]
>+                <a class="nav-link active" href="/cgi-bin/koha/reviews/reviewswaiting.pl" >Comments awaiting moderation</a>
>+            [% END %]
>         </li>
>     </ul> 
>     <div class="tab-content">
>-- 
>2.34.1

Actions: View | Diff | Splinter Review

Attachments on bug 37859: 171192 | 171203 | 171306