When viewing patron comments on records, the tabs are plain text links instead of the standard tabbed style. To replicate: 1. Go to Tools > Patrons and circulation > Comments. 2. Note that tab headings are plain text links, instead of the standard tabbed style. I think this is similar to bug 37752 and bug 37753.
Created attachment 171192 [details] [review] Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views.
Created attachment 171203 [details] [review] Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com>
Thanks Owen and Sukhmandeep!
Created attachment 171306 [details] [review] Bug 37859: Fix style of tabs on comment review page This patch corrects the tab markup on the comment review page. These tabs are just links styled as tabs -- there isn't any JS tab swapping. This kind of "static" tab markup wasn't handled by the tabs WRAPPER work. To test you should have some comments data in your system: - Go to Administration -> System preferences and enable the "OPACComments" preference. - Log in to the OPAC and search for a bibliographic record. - View the detail page for the record and click the "Comments" tab. - Click "Post your comments on this title." - Enter some text in the review box and submit. In the staff interface, go to Tools -> Comments. - You should see two tabs: "Approved comments" and "Comments awaiting moderation." - Confirm that the tabs look correct. - Approve one or more comments and confirm that the tabs work correctly to switch views. Signed-off-by: Sukhmandeep Benipal <sukhmandeep.benipal@inLibro.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Pushed for 24.11! Well done everyone, thank you!