Bugzilla – Attachment 171309 Details for
Bug 37870
UI/Form/Builder/Item.t and Biblio.t are still failing randomly (cn_source sort)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37870: Run tests from ClassSources.t within transactions
Bug-37870-Run-tests-from-ClassSourcest-within-tran.patch (text/plain), 2.08 KB, created by
Tomás Cohen Arazi (tcohen)
on 2024-09-11 13:12:43 UTC
(
hide
)
Description:
Bug 37870: Run tests from ClassSources.t within transactions
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2024-09-11 13:12:43 UTC
Size:
2.08 KB
patch
obsolete
>From b627dfd39ce8edc238cb11aece2b3efba4a95a05 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 10 Sep 2024 10:40:20 +0200 >Subject: [PATCH] Bug 37870: Run tests from ClassSources.t within transactions > >Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/ClassSources.t | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > >diff --git a/t/db_dependent/ClassSources.t b/t/db_dependent/ClassSources.t >index a58a25f507c..98d8f2b988d 100755 >--- a/t/db_dependent/ClassSources.t >+++ b/t/db_dependent/ClassSources.t >@@ -36,6 +36,8 @@ subtest 'GetClassSources' => sub { > > plan tests => 5; > >+ $schema->storage->txn_begin; >+ > my $class_rule = $builder->build( > { > source => 'ClassSortRule', >@@ -82,12 +84,17 @@ subtest 'GetClassSources' => sub { > is( $class_sources_cached->{$source_code}, undef, "New value now present after cache cleared" ); > $class_sources_cached = GetClassSources(); > is_deeply( $class_sources, $class_sources_cached, "New cached version does match the updated fresh version" ); >+ >+ $schema->storage->txn_rollback; >+ > }; > > subtest 'GetClassSource' => sub { > > plan tests => 4; > >+ $schema->storage->txn_begin; >+ > my $class_rule = $builder->build( > { > source => 'ClassSortRule', >@@ -123,12 +130,16 @@ subtest 'GetClassSource' => sub { > $class_source_cache = GetClassSource($source_code); > is( $class_source_cache->{description}, $class_source_db->{description}, "Now both get the correct value" ); > >+ $schema->storage->txn_rollback; >+ > }; > > subtest 'GetClassSortRule' => sub { > > plan tests => 4; > >+ $schema->storage->txn_begin; >+ > my $class_rule_1 = $builder->build( > { > source => 'ClassSortRule', >@@ -153,4 +164,6 @@ subtest 'GetClassSortRule' => sub { > $class_sort_rule_cache = GetClassSortRule($sort_rule); > is_deeply( $class_sort_rule_cache, $class_sort_rule_db, "Now both get the correct value" ); > >+ $schema->storage->txn_rollback; >+ > }; >-- >2.46.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37870
:
171242
|
171243
|
171244
|
171283
|
171284
|
171285
|
171307
|
171308
| 171309 |
171310