Jenkins is failing on: t/db_dependent/Koha/UI/Form/Builder D10 #1626 D12 #3027
Tests passing in ktd for me locally, but haven't tried with specific OS.
More info on bug 32710.
Created attachment 171242 [details] [review] Bug 37870: Remove warning if biblionumber is not passed Not directly related to the failure, only a bit of cleaning before starting.
Created attachment 171243 [details] [review] Bug 37870: Fix sort order of class sources There are several things going on here. The tests are failing randomly when some additional class sources are in the DB. This should never happen on Jenkins, but it happened, see the third patch of this patch set (spoiler: tests not run within a txn) There were also a sorting problem: by default sort will show uppercases first: A, B, C, a, b, c However we want: a, A, b, B, c, C which is what fc does (https://perldoc.perl.org/functions/fc) Test plan: 0. Checkout the main branch, without patches from this patchset. 1. Run t/db_dependent/ClassSources.t several times => Notice that new entries in the DB table 'class_sources' are created 2. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t => They fail (if not, run t/db_dependent/ClassSources.t again) 3. Apply the patches 4. Run t/db_dependent/ClassSources.t => No more additional entries in DB, tests are correctly run within transactions 5. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t several times => They always pass Note that the sort should actually be done on the description, not the code. But that's for another bug...
Created attachment 171244 [details] [review] Bug 37870: Run tests from ClassSources.t within transactions
Created attachment 171283 [details] [review] Bug 37870: Remove warning if biblionumber is not passed Not directly related to the failure, only a bit of cleaning before starting. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Created attachment 171284 [details] [review] Bug 37870: Fix sort order of class sources There are several things going on here. The tests are failing randomly when some additional class sources are in the DB. This should never happen on Jenkins, but it happened, see the third patch of this patch set (spoiler: tests not run within a txn) There were also a sorting problem: by default sort will show uppercases first: A, B, C, a, b, c However we want: a, A, b, B, c, C which is what fc does (https://perldoc.perl.org/functions/fc) Test plan: 0. Checkout the main branch, without patches from this patchset. 1. Run t/db_dependent/ClassSources.t several times => Notice that new entries in the DB table 'class_sources' are created 2. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t => They fail (if not, run t/db_dependent/ClassSources.t again) 3. Apply the patches 4. Run t/db_dependent/ClassSources.t => No more additional entries in DB, tests are correctly run within transactions 5. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t several times => They always pass Note that the sort should actually be done on the description, not the code. But that's for another bug... Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Created attachment 171285 [details] [review] Bug 37870: Run tests from ClassSources.t within transactions Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org>
Everything worked as described!
Created attachment 171307 [details] [review] Bug 37870: Remove warning if biblionumber is not passed Not directly related to the failure, only a bit of cleaning before starting. Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 171308 [details] [review] Bug 37870: Fix sort order of class sources There are several things going on here. The tests are failing randomly when some additional class sources are in the DB. This should never happen on Jenkins, but it happened, see the third patch of this patch set (spoiler: tests not run within a txn) There were also a sorting problem: by default sort will show uppercases first: A, B, C, a, b, c However we want: a, A, b, B, c, C which is what fc does (https://perldoc.perl.org/functions/fc) Test plan: 0. Checkout the main branch, without patches from this patchset. 1. Run t/db_dependent/ClassSources.t several times => Notice that new entries in the DB table 'class_sources' are created 2. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t => They fail (if not, run t/db_dependent/ClassSources.t again) 3. Apply the patches 4. Run t/db_dependent/ClassSources.t => No more additional entries in DB, tests are correctly run within transactions 5. Run t/db_dependent/Koha/UI/Form/Builder/Biblio.t and t/db_dependent/Koha/UI/Form/Builder/Item.t several times => They always pass Note that the sort should actually be done on the description, not the code. But that's for another bug... Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 171309 [details] [review] Bug 37870: Run tests from ClassSources.t within transactions Signed-off-by: CJ Lynce <cj.lynce@westlakelibrary.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Created attachment 171310 [details] [review] Bug 37870: Tidy Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pushed for 24.11! Well done everyone, thank you!
*** Bug 37867 has been marked as a duplicate of this bug. ***
I see it is in 24.05.x Not needed for backport ?