Attachment 171591 Details for Bug 37330 – Bug 37330: (bug 33526 follow-up) Fix display of cover images for items

[patch] Bug 37330: (bug 33526 follow-up) Fix display of cover images for items

Bug-37330-bug-33526-follow-up-Fix-display-of-cover.patch (text/plain), 1.57 KB, created by Nick Clemens (kidclamp) on 2024-09-16 18:11:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-09-16 18:11:32 UTC

Size: 1.57 KB

patch

obsolete

>From feefa9562349a5c3ea97c233c5152767de26315b Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 16 Sep 2024 11:31:45 +0200
>Subject: [PATCH] Bug 37330: (bug 33526 follow-up) Fix display of cover images
> for items
>
>The id has been modified by bug 33526. We can simply pass the table
>element however.
>
>Test plan:
>Have some cover images at item level and notice that they are correctly
>displayed on the bibliographic record detail page.
>
>Note that the slider does not work correctly. If you click on the dot
>(so if you have several images for an item) the scrollbar is going to
>hit the top of the page and the image won't change.
>Could be reported separately if not done yet.
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>index d465aca3847..7a00e941dcf 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt
>@@ -1480,8 +1480,7 @@
>         }
> 
>         let build_items_table_drawncallback = function (table) {
>-            let tab_id = table.parents('.tab-pane').attr('id');
>-            verify_cover_images($("#" + tab_id + '_table'));
>+            verify_cover_images(table);
>         };
> 
>         function removeLocalImage(imagenumber) {
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 37330: 168843 | 171519 | 171522 | 171523 | 171591