Bug 37330 - LocalCoverImages for items don't show if StaffDetailItemSelection disabled
Summary: LocalCoverImages for items don't show if StaffDetailItemSelection disabled
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Pedro Amorim
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-07-11 16:38 UTC by Pedro Amorim
Modified: 2024-07-11 22:52 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37330: Add drawcallback if LocalCoverImages (1.46 KB, patch)
2024-07-11 16:39 UTC, Pedro Amorim
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-07-11 16:38:17 UTC

    
Comment 1 Pedro Amorim 2024-07-11 16:39:33 UTC
Created attachment 168843 [details] [review]
Bug 37330: Add drawcallback if LocalCoverImages

1) Enable LocalCoverImages
2) Visit a biblio:
/cgi-bin/koha/catalogue/detail.pl?biblionumber=294
3) On the actions column, click the arrow and click upload image, submit an image
4) Go back to biblio, notice the image shows for the specific item
5) Disable StaffDetailItemSelection
6) Go back to biblio, notice the image is gone
7) Apply patch. Repeat.
Comment 2 David Nind 2024-07-11 22:52:49 UTC
Something weird is going on here for me with item cover images.

Tested on the latest main, with everything up to date for KTD, and clearing browser caches between changes.

Before the patch, the item cover image is NOT showing for the individual item in the holdings table, but is showing for the record cover images.

This is without the patch and after the patch, and with and without StaffDetailItemSelection enabled.

That is (for me), no item cover images are showing for any of the combinations before and after the patch. I've tested before and after in Firefox and Chromium.

I've also tested with combinations of AllowMultipleCovers, LocalCoverImages, OPACLocalCoverImages.

I thought it may have been something with Bug 33526 - Use template wrapper for tabs: bibliographic detail page and Bug 36966 - Fix links for local cover images for items on staff detail page. These are in main, but if I use 24.05.01 I still get the same behavour.