Bugzilla – Attachment 171661 Details for
Bug 37955
Clicking table's 'configure' button no longer opens column settings page properly
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37955: Fix table's 'configure' button to open correct column settings
Bug-37955-Fix-tables-configure-button-to-open-corr.patch (text/plain), 3.90 KB, created by
Owen Leonard
on 2024-09-18 13:08:38 UTC
(
hide
)
Description:
Bug 37955: Fix table's 'configure' button to open correct column settings
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2024-09-18 13:08:38 UTC
Size:
3.90 KB
patch
obsolete
>From 7dfff4763137c605e2fc980bd6070f473653ca87 Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Wed, 18 Sep 2024 12:57:40 +0000 >Subject: [PATCH] Bug 37955: Fix table's 'configure' button to open correct > column settings > >This patch updates markup and JS code on the table settings page so that >clicking a table's "configure" button will open the right panel and >scroll you to the correct table. > >The patch also overrides Bootstrap's default table caption positioning >so that captions are above the table instead of below them. >Unfortunately this property isn't in Bootstrap's _variables. > >To test, apply the patch and rebuild the staff interface CSS >(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface). > >- Find a table in the staff interface which has a "Configure" button, > e.g. Administration -> Libraries. >- Click the "Configure" button. >- When you arrive at the table settings page the correct panel should be > expanded (in this example, Administration), and the page should scroll > to the correct table (in this example, libraries). > - The table caption ("Table id: libraries") should appear before the > table instead of after. >--- > koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss | 1 + > .../prog/en/modules/admin/columns_settings.tt | 8 ++++---- > 2 files changed, 5 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >index c03802c4f4..52778d458f 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/_tables.scss >@@ -6,6 +6,7 @@ > > table { > border-collapse: collapse; >+ caption-side: top; > > thead { > border-bottom: 2px solid $table-border-color; >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >index 2c435dafb1..0870bd58df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt >@@ -30,7 +30,7 @@ > [% END %] > [% IF tables.$pagename.keys and tables.$pagename.keys.size > 0 %] > [% FOR tablename IN tables.$pagename.keys.sort %] >- [% SET table_id = pagename _ '#' _ tablename %] >+ [% SET table_id = pagename _ '_' _ tablename %] > <div class="datatable_config" id="[% table_id | html %]"> > <input type="hidden" name="table_id" value="[% table_id| html %]" /> > [% IF pagename == 'additem' AND tablename == 'itemst' %] >@@ -369,7 +369,7 @@ > > <div class="col-md-2 order-sm-2 order-md-1"> > <aside> >- [% INCLUDE 'admin-menu.inc' %] >+ [% INCLUDE 'admin-menu.inc' %] > </aside> > </div> <!-- /.col-md-2.order-md-1 --> > </div> <!-- /.row --> >@@ -380,12 +380,12 @@ > [%- IF ( panel.defined ) -%] > <script> > $(document).ready( function() { >- $("#[% panel | uri %]Toggle").click(); >+ $("#[% panel | uri %]_panel").collapse("show"); > [%- IF page.defined -%] > $("#[% panel | uri %]_panel").on('shown.bs.collapse', function () { > $('html, body').animate({ > [%- IF table.defined -%] >- scrollTop: ($("#[% page | uri %]#[% table | uri %]").offset().top) >+ scrollTop: ($("#[% page | uri %]_[% table | uri %]").offset().top) > [%- ELSE -%] > scrollTop: ($("#[% page | uri %]").offset().top) > [%- END -%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37955
:
171661
|
171684
|
171710