Bug 37955 - Clicking table's 'configure' button no longer opens column settings page properly
Summary: Clicking table's 'configure' button no longer opens column settings page prop...
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Staff interface (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Owen Leonard
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks: 38069
  Show dependency treegraph
 
Reported: 2024-09-18 10:36 UTC by Pedro Amorim
Modified: 2024-11-18 22:06 UTC (History)
7 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00
Circulation function:


Attachments
Bug 37955: Fix table's 'configure' button to open correct column settings (3.90 KB, patch)
2024-09-18 13:08 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 37955: Fix table's 'configure' button to open correct column settings (3.94 KB, patch)
2024-09-18 17:01 UTC, David Nind
Details | Diff | Splinter Review
Bug 37955: Fix table's 'configure' button to open correct column settings (4.02 KB, patch)
2024-09-19 07:21 UTC, Jonathan Druart
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-09-18 10:36:04 UTC
When clicking on the 'Configure' button on any table, the column settings page no longer navigates (and expands) the relevant table settings.
Mattermost discussion thread:
https://chat.koha-community.org/koha-community/pl/oarowazpat8kfe4cozbjftidya
Comment 1 Owen Leonard 2024-09-18 13:08:38 UTC
Created attachment 171661 [details] [review]
Bug 37955: Fix table's 'configure' button to open correct column settings

This patch updates markup and JS code on the table settings page so that
clicking a table's "configure" button will open the right panel and
scroll you to the correct table.

The patch also overrides Bootstrap's default table caption positioning
so that captions are above the table instead of below them.
Unfortunately this property isn't in Bootstrap's _variables.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

- Find a table in the staff interface which has a "Configure" button,
  e.g. Administration -> Libraries.
- Click the "Configure" button.
- When you arrive at the table settings page the correct panel should be
  expanded (in this example, Administration), and the page should scroll
  to the correct table (in this example, libraries).
  - The table caption ("Table id: libraries") should appear before the
    table instead of after.
Comment 2 David Nind 2024-09-18 17:01:29 UTC
Created attachment 171684 [details] [review]
Bug 37955: Fix table's 'configure' button to open correct column settings

This patch updates markup and JS code on the table settings page so that
clicking a table's "configure" button will open the right panel and
scroll you to the correct table.

The patch also overrides Bootstrap's default table caption positioning
so that captions are above the table instead of below them.
Unfortunately this property isn't in Bootstrap's _variables.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

- Find a table in the staff interface which has a "Configure" button,
  e.g. Administration -> Libraries.
- Click the "Configure" button.
- When you arrive at the table settings page the correct panel should be
  expanded (in this example, Administration), and the page should scroll
  to the correct table (in this example, libraries).
  - The table caption ("Table id: libraries") should appear before the
    table instead of after.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Jonathan Druart 2024-09-19 07:21:24 UTC
Created attachment 171710 [details] [review]
Bug 37955: Fix table's 'configure' button to open correct column settings

This patch updates markup and JS code on the table settings page so that
clicking a table's "configure" button will open the right panel and
scroll you to the correct table.

The patch also overrides Bootstrap's default table caption positioning
so that captions are above the table instead of below them.
Unfortunately this property isn't in Bootstrap's _variables.

To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_interface).

- Find a table in the staff interface which has a "Configure" button,
  e.g. Administration -> Libraries.
- Click the "Configure" button.
- When you arrive at the table settings page the correct panel should be
  expanded (in this example, Administration), and the page should scroll
  to the correct table (in this example, libraries).
  - The table caption ("Table id: libraries") should appear before the
    table instead of after.

Signed-off-by: David Nind <david@davidnind.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Comment 4 Martin Renvoize (ashimema) 2024-09-19 11:51:37 UTC
Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant
Comment 5 Jonathan Druart 2024-10-03 07:53:09 UTC
table_id was used later, the form cannot be saved, see bug 38069
Comment 6 Lucas Gass (lukeg) 2024-11-18 22:06:08 UTC
Missing 24.05.x deps