Attachment 171857 Details for Bug 36694 – Bug 36694: Remove HC sticky from preferences.tt/authorities.tt

[patch] Bug 36694: Remove HC sticky from preferences.tt/authorities.tt

Bug-36694-Remove-HC-sticky-from-preferencesttautho.patch (text/plain), 4.26 KB, created by Victor Grousset/tuxayo on 2024-09-23 03:19:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2024-09-23 03:19:00 UTC

Size: 4.26 KB

patch

obsolete

>From fbcc09b5677509befcf8dee1b8222125ecc3a94d Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 25 Apr 2024 19:27:24 +0000
>Subject: [PATCH] Bug 36694: Remove HC sticky from
> preferences.tt/authorities.tt
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../prog/en/modules/admin/preferences.tt              | 11 +----------
> .../prog/en/modules/authorities/authorities.tt        | 10 +---------
> 2 files changed, 2 insertions(+), 19 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>index c45dce5cd7..f682965e82 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt
>@@ -60,7 +60,7 @@
>     <h2>[% TAB.tab_title | html %] preferences</h2>
>     <form action="/cgi-bin/koha/admin/preferences.pl" method="post">
>         [% INCLUDE 'csrf-token.inc' %]
>-        [% UNLESS ( searchfield ) %]<div id="toolbar"><button class="save-all btn btn-primary" type="submit">Save all [% TAB.tab_title | html %] preferences</button></div>[% END %]
>+        [% UNLESS ( searchfield ) %]<div id="toolbar" class="sticky"><button class="save-all btn btn-primary" type="submit">Save all [% TAB.tab_title | html %] preferences</button></div>[% END %]
>         <input type="hidden" name="op" value="cud-save" />
>         <input type="hidden" name="tab" value="[% TAB.tab_id | html %]" />
> 
>@@ -277,7 +277,6 @@
> 
> [% MACRO jsinclude BLOCK %]
>     [% INCLUDE 'datatables.inc' %]
>-    [% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]
>     [% Asset.js("lib/jquery/plugins/multiple-select/multiple-select.min.js") | $raw %]
>     [% Asset.js( "lib/codemirror/codemirror.min.js" ) | $raw %]
>     [% Asset.js( "lib/codemirror/css.min.js" ) | $raw %]
>@@ -296,16 +295,8 @@
>     [% Asset.js( "lib/sortable/Sortable.min.js" ) | $raw %]
> 
>     <script>
>-        var Sticky;
>         var themelang = "[% themelang | html %]";
>         $(document).ready(function(){
>-            [% UNLESS ( searchfield ) %]
>-                Sticky = $("#toolbar");
>-                Sticky.hcSticky({
>-                    stickTo: "main",
>-                    stickyClass: "floating"
>-                });
>-            [% END %]
>             $("select[multiple='multiple']").multipleSelect( {
>                 placeholder: _("Please select ..."),
>                 selectAllText: _("Select all"),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>index ea7034eed0..85cf272b90 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt
>@@ -13,7 +13,6 @@
>     [% t("Koha") | html %]
> [% END %]</title>
> [% INCLUDE 'doc-head-close.inc' %]
>-[% Asset.js("lib/hc-sticky/hc-sticky.js") | $raw %]
> [% INCLUDE 'select2.inc' %]
> <script>
>     [% IF Koha.Preference('CreateAVFromCataloguing') && CAN_user_parameters_manage_auth_values %]
>@@ -30,7 +29,6 @@
>     $(window).load(function(){
>         $("#loading").hide();
>     });
>-    var Sticky;
>     $(document).ready(function() {
> 
>         $("a[data-bs-toggle='tab']").on("shown.bs.tab", function (e) {
>@@ -51,12 +49,6 @@
>         initializeSortable("#authoritytabs ul.sortable_field");
>         initializeSortable("#authoritytabs ul.sortable_subfield");
> 
>-        Sticky = $("#toolbar");
>-        Sticky.hcSticky({
>-            stickTo: "#f",
>-            stickyClass: "floating"
>-        });
>-
>         $("#addauth").click(function(){
>             if(Check()){
>                 $("#f").submit();
>@@ -485,7 +477,7 @@
>                     <input type="hidden" value="0" id="confirm_not_duplicate" name="confirm_not_duplicate" />
>                     <input type="hidden" name="changed_authtype" value="" />
> 
>-                    <div id="toolbar" class="btn-toolbar">
>+                    <div id="toolbar" class="btn-toolbar sticky">
>                         <div class="btn-group"><a href="#" id="addauth" class="btn btn-primary" accesskey="w"><i class="fa fa-save"></i> Save</a></div>
>                         <div class="btn-group">
>                             [% IF ( authid ) %]
>-- 
>2.46.1

Actions: View | Diff | Splinter Review

Attachments on bug 36694: 165489 | 165490 | 165491 | 165492 | 165493 | 165576 | 165582 | 165584 | 165587 | 165680 | 165682 | 165683 | 165684 | 165686 | 165756 | 165757 | 165758 | 165759 | 165760 | 165761 | 165762 | 165763 | 165764 | 165765 | 165766 | 165767 | 166703 | 166704 | 166705 | 166706 | 166707 | 166708 | 166709 | 166710 | 166711 | 166712 | 166713 | 166714 | 166715 | 166940 | 167507 | 167508 | 167509 | 167510 | 167511 | 167512 | 167513 | 167514 | 167515 | 167516 | 167517 | 167518 | 167519 | 167520 | 167539 | 167823 | 167824 | 167825 | 167826 | 167827 | 167828 | 167829 | 167830 | 167831 | 167832 | 167833 | 167834 | 167835 | 167836 | 167837 | 169110 | 169111 | 169112 | 169113 | 169114 | 169115 | 169116 | 169117 | 169118 | 169119 | 169120 | 169121 | 169122 | 169123 | 169124 | 169125 | 171080 | 171081 | 171082 | 171083 | 171084 | 171085 | 171086 | 171087 | 171088 | 171089 | 171090 | 171091 | 171092 | 171093 | 171094 | 171095 | 171852 | 171853 | 171854 | 171855 | 171856 | 171857 | 171858 | 171859 | 171860 | 171861 | 171862 | 171863 | 171864 | 171865 | 171866 | 171867