Bugzilla – Attachment 171998 Details for
Bug 37860
Holds Awaiting Pickup table should include the patron main contact method
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 37860: Add Main contact method to Holds awaiting pickup table
Bug-37860-Add-Main-contact-method-to-Holds-awaitin.patch (text/plain), 2.62 KB, created by
Shi Yao Wang
on 2024-09-26 17:54:13 UTC
(
hide
)
Description:
Bug 37860: Add Main contact method to Holds awaiting pickup table
Filename:
MIME Type:
Creator:
Shi Yao Wang
Created:
2024-09-26 17:54:13 UTC
Size:
2.62 KB
patch
obsolete
>From df839326fb4f3f7a0ce0e6ae3eb714a4034760e9 Mon Sep 17 00:00:00 2001 >From: Brendan Lawlor <blawlor@clamsnet.org> >Date: Mon, 9 Sep 2024 15:07:31 +0000 >Subject: [PATCH] Bug 37860: Add Main contact method to Holds awaiting pickup > table > >This patch adds the main contact method to the patron column of the >Holds awaiting pickup table. The style is intended to match the >modal on the hold found modal. > >To test: >1. Apply patch and run yarn build && restart_all >2. Place a hold for a patron and check in the item >3. Notice the modal displays the main contact method in a yellow box >4. Go to Circulation > Holds awaiting pickup >5. Notice the main contact method displays in the Patron column in the same style > >Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> >--- > .../intranet-tmpl/prog/css/src/staff-global.scss | 13 +++++++++++++ > .../prog/en/includes/waiting_holds.inc | 3 +++ > 2 files changed, 16 insertions(+) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >index b708bd36bf..ab46247ed0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >@@ -792,6 +792,19 @@ form { > } > } > >+td .main_contact_method { >+ background-color: #FFE; >+ border: 1px solid #CCC; >+ border-radius: 5px; >+ display: inline-block; >+ margin: .5em 0; >+ padding: .1em .3em; >+ >+ &.none { >+ background-color: #EEE; >+ } >+} >+ > h1 { > } > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >index f654f50c29..3b8e1fa7ce 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/waiting_holds.inc >@@ -58,6 +58,9 @@ > <span class="patron_email"><br /><a href="mailto:[% reserveloo.borrower.notice_email_address | uri %]?subject=[% "Hold waiting: " | uri %][% reserveloo.biblio.title | uri %]"> > [% reserveloo.borrower.notice_email_address | html %]</a></span> > [% END %] >+ [% IF reserveloo.borrower.primary_contact_method %] >+ <span class="main_contact_method">Main contact: [% reserveloo.borrower.primary_contact_method | html %]</span> >+ [% END %] > </td> > <td>[% Branches.GetName( reserveloo.item.homebranch ) | html %]</td> > <td>[% Branches.GetName( reserveloo.item.holdingbranch ) | html %][% IF (reserveloo.desk_id ) %], [% reserveloo.desk.desk_name | html %][% END %]</td> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 37860
:
171207
| 171998