Our library staff would like to see the patron main contact method included in the Holds Awaiting so they can easily tell if they should call up the patron to pickup their holds.
Created attachment 171207 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style
Not sure if this is the best way to do the CSS, but the concept is to make the styling match how main contact method is displayed in the hold found modal. See Bug 33398
Created attachment 171998 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Works, but it seems to display the name of the db column as is. E.g. Secondary email shows "emailpro" in step 3 and 5. Maybe we want to display the actual text? Signed-off nonetheless
Couple easy to fix qa issues: 1) primary_contact_method sees be labeled as "Main contact method" in other templates. Can you update that? 2) The primary_contact_method output needs to be run through a an if/elseif or switch statement to it can be translatable. Here is the code from moremember.tt you could use: [% SWITCH patron.primary_contact_method %] [% CASE 'phone' %] <span>Primary phone</span> [% CASE 'phonepro' %] <span>Secondary phone</span> [% CASE 'mobile' %] <span>Other phone</span> [% CASE 'email' %] <span>Primary email</span> [% CASE 'emailpro' %] <span>Secondary email</span> [% CASE 'fax' %] <span>Fax</span> [% END %]
Created attachment 176880 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Thanks Kyle, I appreciate your help. I made those two changes. Adding the switch statement also addresses Shi Yao's commnet #4.
Looks fine to me. Maybe you want to add a gray chip when there is no primary method, as it is for messaging preference ?
Created attachment 179700 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Thanks for looking Baptiste. I added a grey chip to display Main contact method: None
Created attachment 179715 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com>
Created attachment 179716 [details] [review] Bug 37860: Add Main contact method to Holds awaiting pickup table This patch adds the main contact method to the patron column of the Holds awaiting pickup table. The style is intended to match the modal on the hold found modal. To test: 1. Apply patch and run yarn build && restart_all 2. Place a hold for a patron and check in the item 3. Notice the modal displays the main contact method in a yellow box 4. Go to Circulation > Holds awaiting pickup 5. Notice the main contact method displays in the Patron column in the same style Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com> Signed-off-by: Baptiste Wojtkowski <baptiste.wojtkowski@biblibre.com> Current status: Passed QA