Bug 37860 - Holds Awaiting Pickup table should include the patron main contact method
Summary: Holds Awaiting Pickup table should include the patron main contact method
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Brendan Lawlor
QA Contact: Testopia
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-09-06 21:13 UTC by Brendan Lawlor
Modified: 2024-09-26 17:56 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 37860: Add Main contact method to Holds awaiting pickup table (2.57 KB, patch)
2024-09-09 15:15 UTC, Brendan Lawlor
Details | Diff | Splinter Review
Bug 37860: Add Main contact method to Holds awaiting pickup table (2.62 KB, patch)
2024-09-26 17:54 UTC, Shi Yao Wang
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Brendan Lawlor 2024-09-06 21:13:25 UTC
Our library staff would like to see the patron main contact method included in the Holds Awaiting so they can easily tell if they should call up the patron to pickup their holds.
Comment 1 Brendan Lawlor 2024-09-09 15:15:47 UTC
Created attachment 171207 [details] [review]
Bug 37860: Add Main contact method to Holds awaiting pickup table

This patch adds the main contact method to the patron column of the
Holds awaiting pickup table. The style is intended to match the
modal on the hold found modal.

To test:
1. Apply patch and run yarn build && restart_all
2. Place a hold for a patron and check in the item
3. Notice the modal displays the main contact method in a yellow box
4. Go to Circulation > Holds awaiting pickup
5. Notice the main contact method displays in the Patron column in the same style
Comment 2 Brendan Lawlor 2024-09-09 15:17:54 UTC
Not sure if this is the best way to do the CSS, but the concept is to make the styling match how main contact method is displayed in the hold found modal. See Bug 33398
Comment 3 Shi Yao Wang 2024-09-26 17:54:13 UTC
Created attachment 171998 [details] [review]
Bug 37860: Add Main contact method to Holds awaiting pickup table

This patch adds the main contact method to the patron column of the
Holds awaiting pickup table. The style is intended to match the
modal on the hold found modal.

To test:
1. Apply patch and run yarn build && restart_all
2. Place a hold for a patron and check in the item
3. Notice the modal displays the main contact method in a yellow box
4. Go to Circulation > Holds awaiting pickup
5. Notice the main contact method displays in the Patron column in the same style

Signed-off-by: Shi Yao Wang <shi-yao.wang@inlibro.com>
Comment 4 Shi Yao Wang 2024-09-26 17:56:54 UTC
Works, but it seems to display the name of the db column as is. E.g. Secondary email shows "emailpro" in step 3 and 5. Maybe we want to display the actual text?

Signed-off nonetheless