Attachment 172276 Details for Bug 37730 – Bug 37730: Batch patron modification header scroll

[patch] Bug 37730: Batch patron modification header scroll

Bug-37730-Batch-patron-modification-header-scroll.patch (text/plain), 1.77 KB, created by Nick Clemens (kidclamp) on 2024-10-01 14:20:38 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2024-10-01 14:20:38 UTC

Size: 1.77 KB

patch

obsolete

>From 56ad50018159549db25ffa6c1319038fee2fd62f Mon Sep 17 00:00:00 2001
>From: Chloe Zermatten <chloe.zermatten@ptfs-europe.com>
>Date: Mon, 30 Sep 2024 15:03:23 +0000
>Subject: [PATCH] Bug 37730: Batch patron modification header scroll
>
>When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl,
>there is a point where the table header leaves the normal flow of
>the page to stick to the top of the screen instead. When this
>occurs, the header becomes fixed: if scrolling through the table
>horizontally, only the body will move. This is an issue as it means
>that in this situation, some column headers cannot be viewed and the
>data does not necessarily match the header under which it is found.
>
>This patch resolves this issue by allowing the header to scroll
>horizontally and ensuring that the width of the column headers
>still match that of the columns themselves.
>
>Test plan:
>
>A) Reproduce the bug as per Pedro's intructions:
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>index 46ef2f417d8..e398e1241b0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/modborrowers.tt
>@@ -461,7 +461,8 @@
>             [% IF borrowers %]
>                 let patron_table = KohaTable("borrowerst", {
>                     "order": [[ 1, "asc" ]],
>-                    "autoWidth": false,
>+                    "autoWidth": true,
>+                    "scrollX": true,
>                 }, table_settings);
> 
>                 $("#selectallbutton").click(function() {
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37730: 172229 | 172234 | 172235 | 172276