Bug 37730 - Batch patron modification table horizontal scroll causes headers to mismatch
Summary: Batch patron modification table horizontal scroll causes headers to mismatch
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Chloe Zermatten
QA Contact: Nick Clemens (kidclamp)
URL:
Keywords: Academy, Sandbox
Depends on:
Blocks:
 
Reported: 2024-08-26 11:00 UTC by Pedro Amorim
Modified: 2024-11-18 22:41 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the table for the batch patron modification" tool (Tools > Patrons and circulation > Batch patron modification). When you scrolled down the page so that table header rows are "sticky", and then scrolled to the right, the table header columns were fixed instead of changing to match the column contents.
Version(s) released in:
24.11.00,24.05.06
Circulation function:

Attachments
Bug 37730: Batch patron modification header scroll (2.45 KB, patch)
2024-09-30 15:33 UTC, Chloe Zermatten 		Details | Diff | Splinter Review
Bug 37730: Batch patron modification header scroll (1.76 KB, patch)
2024-09-30 18:33 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37730: Batch patron modification header scroll (2.51 KB, patch)
2024-09-30 18:37 UTC, David Nind 		Details | Diff | Splinter Review
Bug 37730: Batch patron modification header scroll (1.77 KB, patch)
2024-10-01 14:20 UTC, Nick Clemens (kidclamp) 		Details | Diff | Splinter Review
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pedro Amorim 2024-08-26 11:00:02 UTC 

    


    


      



        
          Comment 1
        

        
          Pedro Amorim

        

        
        

        
          2024-08-26 11:00:45 UTC
        

      






To reproduce:

1) Visit "batch patron modification":
<staff_url>/cgi-bin/koha/tools/modborrowers.pl

2) Enter multiple cardnumbers, in k-t-d you may use these:
23529000104159
23529000120056
23529000714163
23529000651225
23529000445172
23529000105040
23529000224510
23529000591678

3) Press "Continue"
4) Scroll down the page enough that the table headers row becomes "detached" and sticks to the top of the page as you scroll down.
5) Scroll the table horizontally. Notice the headers are stuck even though the data columns have moved horizontally, causing the headers and data to not match.

    


    


      



        
          Comment 2
        

        
          Chloe Zermatten

        

        
        

        
          2024-09-30 15:33:48 UTC
        

      






Created attachment 172229 [details] [review]
Bug 37730: Batch patron modification header scroll

When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl,
there is a point where the table header leaves the normal flow of
the page to stick to the top of the screen instead. When this
occurs, the header becomes fixed: if scrolling through the table
horizontally, only the body will move. This is an issue as it means
that in this situation, some column headers cannot be viewed and the
data does not necessarily match the header under which it is found.

This patch resolves this issue by allowing the header to scroll
horizontally and ensuring that the width of the column headers
still match that of the columns themselves.

Test plan:

A) Reproduce the bug as per Pedro's intructions:

---
1) Visit "batch patron modification":
<staff_url>/cgi-bin/koha/tools/modborrowers.pl
2) Enter multiple cardnumbers, in k-t-d you may use these:
23529000104159
23529000120056
23529000714163
23529000651225
23529000445172
23529000105040
23529000224510
23529000591678
3) Press "Continue"
4) Scroll down the page enough that the table headers row becomes "detached" and sticks to the top of the page as you scroll down.
5) Scroll the table horizontally. Notice the headers are stuck even though the data columns have moved horizontally, causing the headers and data to not match.
---

B) Apply the patch
C) Go through steps 1-5 again. This time, notice that the header scrolls along with the table body and that the column headers and data always match.

    


    


      

          
            
          


        
          Comment 3
        

        
          David Nind

        

        
        

        
          2024-09-30 18:33:29 UTC
        

          
            Comment hidden (obsolete)
          
      






    


    


      



        
          Comment 4
        

        
          David Nind

        

        
        

        
          2024-09-30 18:37:18 UTC
        

      






Created attachment 172235 [details] [review]
Bug 37730: Batch patron modification header scroll

When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl,
there is a point where the table header leaves the normal flow of
the page to stick to the top of the screen instead. When this
occurs, the header becomes fixed: if scrolling through the table
horizontally, only the body will move. This is an issue as it means
that in this situation, some column headers cannot be viewed and the
data does not necessarily match the header under which it is found.

This patch resolves this issue by allowing the header to scroll
horizontally and ensuring that the width of the column headers
still match that of the columns themselves.

Test plan:

A) Reproduce the bug as per Pedro's intructions:

---
1) Visit "batch patron modification":
<staff_url>/cgi-bin/koha/tools/modborrowers.pl
2) Enter multiple cardnumbers, in k-t-d you may use these:
23529000104159
23529000120056
23529000714163
23529000651225
23529000445172
23529000105040
23529000224510
23529000591678
3) Press "Continue"
4) Scroll down the page enough that the table headers row becomes "detached"
   and sticks to the top of the page as you scroll down.
5) Scroll the table horizontally. Notice the headers are stuck even though
   the data columns have moved horizontally, causing the headers and data to
   not match.
---

B) Apply the patch
C) Go through steps 1-5 again. This time, notice that the header scrolls
   along with the table body and that the column headers and data always match.

Signed-off-by: David Nind <david@davidnind.com>

    


    


      



        
          Comment 5
        

        
          David Nind

        

        
        

        
          2024-09-30 18:44:11 UTC
        

      






Something went weird when I attached the signed off bug - most of the test plan was missing.

I've amended the commit message to include the test plan and attached again.

    


    


      



        
          Comment 6
        

        
          Nick Clemens (kidclamp)

        

        
        

        
          2024-10-01 14:20:38 UTC
        

      






Created attachment 172276 [details] [review]
Bug 37730: Batch patron modification header scroll

When scroling down <staff_url>/cgi-bin/koha/tools/modborrowers.pl,
there is a point where the table header leaves the normal flow of
the page to stick to the top of the screen instead. When this
occurs, the header becomes fixed: if scrolling through the table
horizontally, only the body will move. This is an issue as it means
that in this situation, some column headers cannot be viewed and the
data does not necessarily match the header under which it is found.

This patch resolves this issue by allowing the header to scroll
horizontally and ensuring that the width of the column headers
still match that of the columns themselves.

Test plan:

A) Reproduce the bug as per Pedro's intructions:

Signed-off-by: Nick Clemens <nick@bywatersolutions.com>

    


    


      



        
          Comment 7
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2024-10-02 09:20:02 UTC
        

      






It's the `---`.. those have meaning in git from the looks of it and thus they end up cutting the message.

I've amended them to `***` and added them back into the commit with the signoffs

    


    


      



        
          Comment 8
        

        
          Martin Renvoize (ashimema)

        

        
        

        
          2024-10-02 09:56:18 UTC
        

      






Thanks for all the hard work!

Pushed to main for the next 24.11.00 release as RM Assistant

    


    


      



        
          Comment 9
        

        
          Lucas Gass (lukeg)

        

        
        

        
          2024-11-18 22:41:33 UTC
        

      






Backported to 24.05.x for upcoming 24.05.06