Attachment 172402 Details for Bug 38094 – Bug 38094 - Librarians with only fast add permission can no longer edit fast add records

[patch] Bug 38094 - Librarians with only fast add permission can no longer edit fast add records

Bug-38094---Librarians-with-only-fast-add-permissi.patch (text/plain), 1.52 KB, created by Kyle M Hall (khall) on 2024-10-04 14:12:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-10-04 14:12:04 UTC

Size: 1.52 KB

patch

obsolete

>From 845db9402d1274033b8b4e30bccc9f47b61e3507 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 4 Oct 2024 10:10:13 -0400
>Subject: [PATCH] Bug 38094 - Librarians with only fast add permission can no
> longer edit fast add records
>
>The ability to create fast add records was fixed on bug 38076, but they still cannot be edited after they are saved.
>
>Test Plan:
>1) Create a librarian with only fast add cataloging permissions
>2) Create a fast add record, save it
>3) Attempt to edit that record, you cannot!
>4) Apply this patch
>5) Restart all the things!
>6) Attempt to edit that record, you can!
>7) Attempt to edit a non-FA record, you cannot!
>---
> Koha/Biblio.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Biblio.pm b/Koha/Biblio.pm
>index 0f9d4cd877b..5ef19b48c99 100644
>--- a/Koha/Biblio.pm
>+++ b/Koha/Biblio.pm
>@@ -263,8 +263,10 @@ sub can_be_edited {
>     Koha::Exceptions::MissingParameter->throw( error => "The patron parameter is missing or invalid" )
>         unless $patron && ref($patron) eq 'Koha::Patron';
> 
>+    my $editcatalogue = $self->frameworkcode eq 'FA' ? 'fast_cataloging' : 'edit_catalogue';
>+
>     return (
>-        ( $self->metadata->source_allows_editing && $patron->has_permission( { editcatalogue => 'edit_catalogue' } ) )
>+        ( $self->metadata->source_allows_editing && $patron->has_permission( { editcatalogue => $editcatalogue } ) )
>             || $patron->has_permission( { editcatalogue => 'edit_locked_records' } ) ) ? 1 : 0;
> }
> 
>-- 
>2.39.5 (Apple Git-154)

Actions: View | Diff | Splinter Review

Attachments on bug 38094: 172402 | 172403 | 172404 | 172405 | 172406 | 172407 | 172408 | 172409 | 172410