Attachment 172493 Details for Bug 37109 – Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

[patch] Bug 37109: Don't initialise claims fields when duplicating acquisitions orders

Bug-37109-Dont-initialise-claims-fields-when-dupli.patch (text/plain), 2.02 KB, created by Kyle M Hall (khall) on 2024-10-07 16:13:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2024-10-07 16:13:11 UTC

Size: 2.02 KB

patch

obsolete

>From bf075ec1da86b5b97b667e4bf46dcc78eb03963f Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Tue, 18 Jun 2024 03:29:32 +0000
>Subject: [PATCH] Bug 37109: Don't initialise claims fields when duplicating
> acquisitions orders
>
>These fields don't exist in the aqorders table and don't need to be
>set/passed on.
>
>* claims_count (dropped in Bug 24161)
>* claimed_date (dropped in Bug 24161)
>* placed_on (no evidence of this field existing in aqorders)
>* received_on (no evidence of this field existing in aqorders)
>
>To test:
>
>1. Go to Acquisitions
>2. Create a vendor if you don't already have one
>3. Create a basket if you don't already have one
>4. Add an order to the basket and Save
>5. Add another order to the basket, choose "From existing orders
>   (copy)"
>6. Continue through the process and confirm you're able to duplicate the
>   order as normal
>7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t
>
>Sponsored-by: Catalyst IT
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> Koha/Acquisition/Order.pm | 4 ----
> 1 file changed, 4 deletions(-)
>
>diff --git a/Koha/Acquisition/Order.pm b/Koha/Acquisition/Order.pm
>index d869b9764da..b8399e3524c 100644
>--- a/Koha/Acquisition/Order.pm
>+++ b/Koha/Acquisition/Order.pm
>@@ -450,20 +450,16 @@ sub duplicate_to {
>             for my $field (
>                 qw(
>                 ordernumber
>-                received_on
>                 datereceived
>                 invoiceid
>                 datecancellationprinted
>                 cancellationreason
>-                claims_count
>-                claimed_date
>                 parent_ordernumber
>                 )
>               )
>             {
>                 undef $order_info->{$field};
>             }
>-            $order_info->{placed_on}        = dt_from_string;
>             $order_info->{entrydate}        = dt_from_string;
>             $order_info->{orderstatus}      = 'new';
>             $order_info->{quantityreceived} = 0;
>-- 
>2.39.5 (Apple Git-154)

Actions: View | Diff | Splinter Review

Attachments on bug 37109: 167816 | 167817 | 167822 | 172493