The following fields that used to be in the aqorders table for claims are still initialised when duplicating orders. They aren't stored anywhere so don't cause a problem, but they don't need to be set at all. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders)
Created attachment 167816 [details] [review] Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT
Created attachment 167817 [details] [review] Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT
Created attachment 167822 [details] [review] Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Created attachment 172493 [details] [review] Bug 37109: Don't initialise claims fields when duplicating acquisitions orders These fields don't exist in the aqorders table and don't need to be set/passed on. * claims_count (dropped in Bug 24161) * claimed_date (dropped in Bug 24161) * placed_on (no evidence of this field existing in aqorders) * received_on (no evidence of this field existing in aqorders) To test: 1. Go to Acquisitions 2. Create a vendor if you don't already have one 3. Create a basket if you don't already have one 4. Add an order to the basket and Save 5. Add another order to the basket, choose "From existing orders (copy)" 6. Continue through the process and confirm you're able to duplicate the order as normal 7. Confirm tests still pass t/db_dependent/Koha/Acquisition/Order.t Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
I think placed_on refers to aqorders.creationdate and received_on to datereceived, but at the same time you would not want to duplicate these.
Pushed for 24.11! Well done everyone, thank you!
release notes added
Enhancement, no 24.05.x backport