Attachment 172558 Details for Bug 38128 – Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission

[patch] Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission

Bug-38128-Bug-35329-follow-up-Filter-ERM-users-to-.patch (text/plain), 1.55 KB, created by Pedro Amorim on 2024-10-09 08:00:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-09 08:00:24 UTC

Size: 1.55 KB

patch

obsolete

>From f90373f28898dae4f9d244d4ce36b818890f6328 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 9 Oct 2024 09:29:47 +0200
>Subject: [PATCH] Bug 38128: (Bug 35329 follow-up) Filter ERM users to users
> with erm permission
>
>There was a silly mistake, we passed the TT var erm_users instead of the
>string "erm_users".
>It should also be passed to patron_search_modal to display the note.
>
>Test plan:
>Confirm that with this patch a patron search in the ERM module returns
>only patrons with the erm permission.
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt
>index 76746b5cd8b..768c8e8596e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/erm/erm.tt
>@@ -51,8 +51,9 @@
>     [% Asset.js("js/vue/dist/erm.js") | $raw %]
>     [% INCLUDE 'select2.inc' %]
>     [% SET columns = ['cardnumber','name','category','branch','action'] %]
>+    [% SET filter = "erm_users" %]
>     [% PROCESS patron_search_modal columns => columns, modal_title => t("Select user") %]
>-    [% PROCESS patron_search_js columns => columns, filter => erm_users, actions => ["select"], preview_on_name_click => 1 %]
>+    [% PROCESS patron_search_js columns => columns, actions => ["select"], preview_on_name_click => 1 %]
> 
> [% END %]
> [% INCLUDE 'intranet-bottom.inc' %]
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38128: 172556 | 172558 | 173510 | 174111