The manual says that the user selection in ERM agreements and licences are limited to patrons with erm permissions. This is no longer true. I don't know if it is intentional, or a simple omission (possibly from Bug 35329). It made sense to limit the patron search this way, I think. To get there: 1. Enable ERMModule 2. Go to E-resource management > Agreement > New agreement 3. Click 'Add new user' 4. Click 'Select user' 5. Search for alford (for example) --> Jordan Alford is in the results, even if they don't have erm permissions 6. Go to Licences > New licence 7. Repeat steps 3-5 --> Jordan Alford is in the results, even if they don't have erm permissions I tried on a local 23.05 installation and Jordan Alford is not in the results, because they don't have erm permissions.
Created attachment 172556 [details] [review] Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission.
Created attachment 172558 [details] [review] Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
@Caroline are you able to test this, as the original reporter of the bug? If you're able to add your SO, we can change mine to PQA to help this move in the queue.
Created attachment 173510 [details] [review] Bug 38128: (Bug 35329 follow-up) Filter ERM users to users with erm permission There was a silly mistake, we passed the TT var erm_users instead of the string "erm_users". It should also be passed to patron_search_modal to display the note. Test plan: Confirm that with this patch a patron search in the ERM module returns only patrons with the erm permission. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Created attachment 174111 [details] [review] Bug 38128: Fix cypress test We were mocking the wrong route.
(In reply to Jonathan Druart from comment #6) > Created attachment 174111 [details] [review] [review] > Bug 38128: Fix cypress test > > We were mocking the wrong route. Thanks, picked follow-up for main.