Attachment 172825 Details for Bug 37204 – Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter

[patch] Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter

Bug-37204-QA-follow-up-Pass-oldbooking-into-GetPre.patch (text/plain), 1.20 KB, created by Martin Renvoize (ashimema) on 2024-10-16 15:40:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2024-10-16 15:40:18 UTC

Size: 1.20 KB

patch

obsolete

>From 96946b370504bd4d74dac082694e8e12a0faec07 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 16 Oct 2024 16:34:58 +0100
>Subject: [PATCH] Bug 37204: (QA follow-up) Pass old_booking into
> GetPreparedLetter
>
>Thinking about the future, some libraries may wish to use the
>old_booking object details in their notice so I opt to pass it into
>GetPreparedLetter here to support that.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> Koha/Booking.pm | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Booking.pm b/Koha/Booking.pm
>index c16ae91c4f4..f3376af918d 100644
>--- a/Koha/Booking.pm
>+++ b/Koha/Booking.pm
>@@ -167,7 +167,10 @@ sub store {
>                     message_transport_type => 'email',
>                     branchcode             => $pickup_library->branchcode,
>                     lang                   => $patron->lang,
>-                    objects                => { booking => $self },
>+                    objects                => {
>+                        old_booking => $old_booking,
>+                        booking     => $self
>+                    },
>                 );
> 
>                 if ($letter) {
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 37204: 170805 | 170939 | 172824 | 172825 | 172826 | 172827 | 172828 | 173283 | 173284 | 173285