Bug 37204 - Add a booking has changed notice to update a patron should a booking be updated
Summary: Add a booking has changed notice to update a patron should a booking be updated
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low enhancement
Assignee: Paul Derscheid
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 36915
Blocks: 37803 38490 38501
  Show dependency treegraph
 
Reported: 2024-06-26 15:20 UTC by Martin Renvoize (ashimema)
Modified: 2024-11-21 09:48 UTC (History)
7 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This enhancement introduces a notice to inform patrons of changes to their bookings, such as updates to the pickup library, start date, or end date, ensuring clear communication regarding any modifications.
Version(s) released in:
24.11.00
Circulation function: bookings


Attachments
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated (7.70 KB, patch)
2024-08-28 11:31 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated (7.74 KB, patch)
2024-09-02 12:41 UTC, Biblibre Sandboxes
Details | Diff | Splinter Review
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated (7.81 KB, patch)
2024-10-16 15:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter (1.20 KB, patch)
2024-10-16 15:40 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Consistently pick notice library (2.03 KB, patch)
2024-10-16 15:46 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Consistently pick notice library (2.05 KB, patch)
2024-10-16 15:47 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Consistently pick notice library (3.39 KB, patch)
2024-10-16 15:51 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated (7.97 KB, patch)
2024-10-24 15:12 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter (1.36 KB, patch)
2024-10-24 15:12 UTC, Paul Derscheid
Details | Diff | Splinter Review
Bug 37204: (QA follow-up) Consistently pick notice library (3.55 KB, patch)
2024-10-24 15:12 UTC, Paul Derscheid
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Renvoize (ashimema) 2024-06-26 15:20:40 UTC
Sometimes a booking may need to be tweaked, the item assigned changed or the dates shifted slightly.

We need a notice to let the patron know about the change and why.
Comment 1 Paul Derscheid 2024-08-28 11:31:30 UTC
Created attachment 170805 [details] [review]
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated

This is a first draft. When reading your initial statement again I'm asking myself whether
a changed itemnumber is relevant to the patron.
The way I see it, the relevant fields are:
- pickup_library_id
- start_date
- end_date

But maybe I'm not seeing it.

To test:
1) Apply the patch
2) Make an item bookable
3) Add a booking for a given patron
4) Check the patron notices tab, should not contain any notices
5) Change either start date, end date or pickup library and save
6) Check the patron notices tab, should contain a notice with the updated details
7) Run the tests under t/db_dependent/Koha/Booking.t
8) Sign off
Comment 2 Paul Derscheid 2024-08-28 11:33:23 UTC
Addendum:
1.1) Run reset_all on ktd to include the new sample notice for BOOKING_MODIFICATION
Comment 3 Biblibre Sandboxes 2024-09-02 12:41:48 UTC
Created attachment 170939 [details] [review]
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated

This is a first draft. When reading your initial statement again I'm asking myself whether
a changed itemnumber is relevant to the patron.
The way I see it, the relevant fields are:
- pickup_library_id
- start_date
- end_date

But maybe I'm not seeing it.

To test:
1) Apply the patch
2) Make an item bookable
3) Add a booking for a given patron
4) Check the patron notices tab, should not contain any notices
5) Change either start date, end date or pickup library and save
6) Check the patron notices tab, should contain a notice with the updated details
7) Run the tests under t/db_dependent/Koha/Booking.t
8) Sign off

Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Comment 4 Martin Renvoize (ashimema) 2024-10-16 15:40:16 UTC
Created attachment 172824 [details] [review]
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated

This is a first draft. When reading your initial statement again I'm asking myself whether
a changed itemnumber is relevant to the patron.
The way I see it, the relevant fields are:
- pickup_library_id
- start_date
- end_date

But maybe I'm not seeing it.

To test:
1) Apply the patch
2) Make an item bookable
3) Add a booking for a given patron
4) Check the patron notices tab, should not contain any notices
5) Change either start date, end date or pickup library and save
6) Check the patron notices tab, should contain a notice with the updated details
7) Run the tests under t/db_dependent/Koha/Booking.t
8) Sign off

Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Martin Renvoize (ashimema) 2024-10-16 15:40:18 UTC
Created attachment 172825 [details] [review]
Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter

Thinking about the future, some libraries may wish to use the
old_booking object details in their notice so I opt to pass it into
GetPreparedLetter here to support that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 6 Martin Renvoize (ashimema) 2024-10-16 15:40:41 UTC
Thanks Paul.
Comment 7 Martin Renvoize (ashimema) 2024-10-16 15:46:38 UTC
Created attachment 172826 [details] [review]
Bug 37204: (QA follow-up) Consistently pick notice library

We should use the notice from the library that initiated the action that
triggered the notice. This should be available to us always in the
userenv.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 8 Martin Renvoize (ashimema) 2024-10-16 15:47:25 UTC
Created attachment 172827 [details] [review]
Bug 37204: (QA follow-up) Consistently pick notice library

We should use the notice from the library that initiated the action that
triggered the notice. This should be available to us always in the
userenv.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 9 Martin Renvoize (ashimema) 2024-10-16 15:51:12 UTC
Created attachment 172828 [details] [review]
Bug 37204: (QA follow-up) Consistently pick notice library

We should use the notice from the library that initiated the action that
triggered the notice. This should be available to us always in the
userenv.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 10 Paul Derscheid 2024-10-24 15:12:53 UTC
Created attachment 173283 [details] [review]
Bug 37204: Add a booking has changed notice to update a patron should a booking be updated

This is a first draft. When reading your initial statement again I'm asking myself whether
a changed itemnumber is relevant to the patron.
The way I see it, the relevant fields are:
- pickup_library_id
- start_date
- end_date

But maybe I'm not seeing it.

To test:
1) Apply the patch
2) Make an item bookable
3) Add a booking for a given patron
4) Check the patron notices tab, should not contain any notices
5) Change either start date, end date or pickup library and save
6) Check the patron notices tab, should contain a notice with the updated details
7) Run the tests under t/db_dependent/Koha/Booking.t
8) Sign off

Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Comment 11 Paul Derscheid 2024-10-24 15:12:56 UTC
Created attachment 173284 [details] [review]
Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter

Thinking about the future, some libraries may wish to use the
old_booking object details in their notice so I opt to pass it into
GetPreparedLetter here to support that.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Comment 12 Paul Derscheid 2024-10-24 15:12:58 UTC
Created attachment 173285 [details] [review]
Bug 37204: (QA follow-up) Consistently pick notice library

We should use the notice from the library that initiated the action that
triggered the notice. This should be available to us always in the
userenv.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Comment 13 Katrin Fischer 2024-10-24 16:28:03 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 14 Lucas Gass (lukeg) 2024-11-18 23:05:45 UTC
Enhancement, no 24.05.x backport
Comment 15 Katrin Fischer 2024-11-19 14:40:16 UTC
This adds a new notice, so needs documenting.