Sometimes a booking may need to be tweaked, the item assigned changed or the dates shifted slightly. We need a notice to let the patron know about the change and why.
Created attachment 170805 [details] [review] Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off
Addendum: 1.1) Run reset_all on ktd to include the new sample notice for BOOKING_MODIFICATION
Created attachment 170939 [details] [review] Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de>
Created attachment 172824 [details] [review] Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 172825 [details] [review] Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter Thinking about the future, some libraries may wish to use the old_booking object details in their notice so I opt to pass it into GetPreparedLetter here to support that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Thanks Paul.
Created attachment 172826 [details] [review] Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 172827 [details] [review] Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 172828 [details] [review] Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Created attachment 173283 [details] [review] Bug 37204: Add a booking has changed notice to update a patron should a booking be updated This is a first draft. When reading your initial statement again I'm asking myself whether a changed itemnumber is relevant to the patron. The way I see it, the relevant fields are: - pickup_library_id - start_date - end_date But maybe I'm not seeing it. To test: 1) Apply the patch 2) Make an item bookable 3) Add a booking for a given patron 4) Check the patron notices tab, should not contain any notices 5) Change either start date, end date or pickup library and save 6) Check the patron notices tab, should contain a notice with the updated details 7) Run the tests under t/db_dependent/Koha/Booking.t 8) Sign off Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173284 [details] [review] Bug 37204: (QA follow-up) Pass old_booking into GetPreparedLetter Thinking about the future, some libraries may wish to use the old_booking object details in their notice so I opt to pass it into GetPreparedLetter here to support that. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Created attachment 173285 [details] [review] Bug 37204: (QA follow-up) Consistently pick notice library We should use the notice from the library that initiated the action that triggered the notice. This should be available to us always in the userenv. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Sponsored-by: Büchereizentrale Schleswig-Holstein <https://www.bz-sh.de/>
Pushed for 24.11! Well done everyone, thank you!
Enhancement, no 24.05.x backport
This adds a new notice, so needs documenting.