Bugzilla – Attachment 172937 Details for
Bug 38199
Printing transfer slips from circ/returns.pl doesn't set focus properly ( 24.05.x and below )
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38199: [24.05.x] Add back missing print class
Bug-38199-2405x-Add-back-missing-print-class.patch (text/plain), 2.87 KB, created by
Lucas Gass (lukeg)
on 2024-10-17 23:53:02 UTC
(
hide
)
Description:
Bug 38199: [24.05.x] Add back missing print class
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2024-10-17 23:53:02 UTC
Size:
2.87 KB
patch
obsolete
>From 7fe160eafbb3160361f1531e36e44b247e85e3d6 Mon Sep 17 00:00:00 2001 >From: Lucas Gass <lucas@bywatersolutions.com> >Date: Thu, 17 Oct 2024 23:45:06 +0000 >Subject: [PATCH] Bug 38199: [24.05.x] Add back missing print class > >To test: >1. Find an item to checkout that doesn't belong to the branch you are logged in at. >2. Check the item out. >3. Go to Circulation > Check in >4. Using the check in input in the main area ("Check in"), check the item in >5. A modal should appear, "Please return this item to {branch}" >6. Click "Print slip" >7. Deal with the browsers print dialouge. ( print, cancel, or save should work for testing) >8. After the modal closes focus is not brought back to the barcode field. >9. Check the item in again, this should trigger the "Wrong transfer detected, please return item to: {branch}" modal. >10. Click "Print transfer slip", here the modal closes and properly gives focus to the #barcode input. >11. APPLY PATCH, clear browser cache. >12. Try all the steps again, each time focus should be restored to the #barcode input >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index 7091e5ef8e7..9d38faf3220 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -782,7 +782,7 @@ > <button type="button" data-dismiss="modal" class="btn btn-default deny" name="notransfer" value="No" accesskey="n"><i class="fa fa-times"></i> No (N)</button> > [% ELSE %] > <button type="button" data-dismiss="modal" class="btn btn-default" accesskey="y"><i class="fa fa-check"></i> OK (Y)</button> >- <button type="button" data-dismiss="modal" class="btn btn-default openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&branchcode=[% transfer | uri %]&op=slip" accesskey="p"><i class="fa fa-print"></i> Print slip (P)</button> >+ <button type="button" data-dismiss="modal" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&branchcode=[% transfer | uri %]&op=slip" accesskey="p"><i class="fa fa-print"></i> Print slip (P)</button> > [% END %] > <input type="hidden" name="return_date_override" value="[% return_date_override | html %]" /> > <input type="hidden" name="return_date_override_remember" value="[% return_date_override_remember | html %]" /> >-- >2.39.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38199
: 172937