Bug 38199 - Printing transfer slips from circ/returns.pl doesn't set focus properly ( 24.05.x and below )
Summary: Printing transfer slips from circ/returns.pl doesn't set focus properly ( 24....
Status: Needs documenting
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 24.05
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Testopia
URL:
Keywords:
Depends on: 34478
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-17 23:40 UTC by Lucas Gass (lukeg)
Modified: 2024-10-25 14:02 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.05.05
Circulation function:


Attachments
Bug 38199: [24.05.x] Add back missing print class (2.87 KB, patch)
2024-10-17 23:53 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass (lukeg) 2024-10-17 23:40:53 UTC
This problem is fixed in main by Bug 35402. ( commit 5fe1ad8ac66072ef7e06d21d0ccc48d388ecaf79 )

-                                                        <button type="button" data-dismiss="modal" class="btn btn-default" accesskey="y"><i class="fa fa-check"></i> OK (Y)</button>
-                                                        <button type="button" data-dismiss="modal" class="btn btn-default openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;branchcode=[% transfer | uri %]&amp;op=slip" accesskey="p"><i class="fa fa-print"></i> Print slip (P)</button>
+                                                        <button type="button" data-bs-dismiss="modal" class="btn btn-default" accesskey="y"><i class="fa fa-check"></i> OK (Y)</button>
+                                                        <button type="button" data-bs-dismiss="modal" class="btn btn-default print openWin" data-url="transfer-slip.pl?transferitem=[% itemnumber | uri %]&amp;branchcode=[% transfer | uri %]&amp;op=slip" accesskey="p"><i class="fa fa-print"></i> Print slip (P)</button>


We need the same fix in 24.05.x and below.
Comment 1 Lucas Gass (lukeg) 2024-10-17 23:41:27 UTC
This fix we just need to add the print class, I think.
Comment 2 Lucas Gass (lukeg) 2024-10-17 23:53:02 UTC
Created attachment 172937 [details] [review]
Bug 38199: [24.05.x] Add back missing print class

To test:
1. Find an item to checkout that doesn't belong to the branch you are logged in at.
2. Check the item out.
3. Go to Circulation > Check in
4. Using the check in input in the main area ("Check in"), check the item in
5. A modal should appear, "Please return this item to {branch}"
6. Click "Print slip"
7. Deal with the browsers print dialouge. ( print, cancel, or save should work for testing)
8. After the modal closes focus is not brought back to the barcode field.
9. Check the item in again, this should trigger the "Wrong transfer detected, please return item to: {branch}" modal.
10. Click "Print transfer slip", here the modal closes and properly gives focus to the #barcode input.
11. APPLY PATCH, clear browser cache.
12. Try all the steps again, each time focus should be restored to the #barcode input
Comment 3 Lucas Gass (lukeg) 2024-10-23 22:54:43 UTC
Backported to 24.05.x for upcoming 24.05.05
Comment 4 Fridolin Somers 2024-10-25 14:02:31 UTC
Comes from :
Bug 34478: Manual fix - add cud- ops or remove form submit - returns.tt / checkin-search-box.inc

Not in 23.11.x