Attachment 173161 Details for Bug 36064 – Bug 36064: (QA follow-up) Simplify and tidy

[patch] Bug 36064: (QA follow-up) Simplify and tidy

Bug-36064-QA-follow-up-Simplify-and-tidy.patch (text/plain), 1.32 KB, created by Tomás Cohen Arazi (tcohen) on 2024-10-22 14:19:39 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2024-10-22 14:19:39 UTC

Size: 1.32 KB

patch

obsolete

>From 11312ec472b5b7bb12978af3bbd30f2c47be3707 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Tue, 22 Oct 2024 11:17:34 -0300
>Subject: [PATCH] Bug 36064: (QA follow-up) Simplify and tidy
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> mainpage.pl | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/mainpage.pl b/mainpage.pl
>index 44689e87cf5..d84408538e1 100755
>--- a/mainpage.pl
>+++ b/mainpage.pl
>@@ -125,7 +125,8 @@ unless ( $logged_in_user->has_permission( { parameters => 'manage_background_job
>     $template->param( already_ran_jobs => $already_ran_jobs );
> }
> 
>-my $holds_with_cancellation_requests = Koha::Holds->waiting->search()->filter_by_has_cancellation_requests->count;
>+$template->param(
>+    holds_with_cancellation_requests => Koha::Holds->waiting->filter_by_has_cancellation_requests->count );
> 
> if ( C4::Context->preference('CurbsidePickup') ) {
>     $template->param(
>@@ -144,7 +145,6 @@ $template->param(
>     pending_discharge_requests     => $pending_discharge_requests,
>     pending_article_requests       => $pending_article_requests,
>     pending_problem_reports        => $pending_problem_reports,
>-    holds_with_cancellation_requests => $holds_with_cancellation_requests,
> );
> 
> output_html_with_http_headers $query, $cookie, $template->output;
>-- 
>2.47.0

Actions: View | Diff | Splinter Review

Attachments on bug 36064: 161998 | 161999 | 162002 | 162105 | 165796 | 165797 | 165798 | 165799 | 165809 | 165810 | 165823 | 165824 | 170654 | 170655 | 173159 | 173160 | 173161