Bug 36064 - Add Holds with cancellation requests info to intranet-main page
Summary: Add Holds with cancellation requests info to intranet-main page
Status: Needs Signoff
Alias: None
Product: Koha
Classification: Unclassified
Component: Hold requests (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement (vote)
Assignee: Lucas Gass
QA Contact: Testopia
URL:
Keywords:
Depends on: 36063 22456
Blocks:
  Show dependency treegraph
 
Reported: 2024-02-09 23:55 UTC by Lucas Gass
Modified: 2024-02-13 12:02 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 36064: Add holds with cancellation request info to staff interface main page (5.32 KB, patch)
2024-02-10 00:03 UTC, Lucas Gass
Details | Diff | Splinter Review
Bug 36064: Add holds with cancellation request info to staff interface main page (5.37 KB, patch)
2024-02-10 02:13 UTC, David Nind
Details | Diff | Splinter Review
Bug 36064: Add holds with cancellation request info to staff interface main page (5.43 KB, patch)
2024-02-10 17:09 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 36064: (follow-up) Activate correct tab (3.61 KB, patch)
2024-02-13 12:02 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Lucas Gass 2024-02-09 23:55:46 UTC
Some librarians would like to see notice/warning on the staff interface main page if there are holds with cancellation requests. 

Like Bug 36063 but for holds with cancellation requests.
Comment 1 Lucas Gass 2024-02-10 00:03:20 UTC Comment hidden (obsolete)
Comment 2 David Nind 2024-02-10 02:13:27 UTC Comment hidden (obsolete)
Comment 3 ByWater Sandboxes 2024-02-10 17:09:22 UTC
Created attachment 162002 [details] [review]
Bug 36064: Add holds with cancellation request info to staff interface main page

To Test:
1. APPLY PATCH, restart_all
2. Make some holds
3. Make sure there is a Default waiting hold cancellation policy.
4. Make the holds watiing by checking them in.
5. Go to the OPAC and request to cancel.
6. Go to the staff interface home page, you should see 'Holds with cancellation requests: X'.
7. Cancel the hold.
8. Back on the main page it should not be counted again the number for 'Holds with cancellation requests: X'
9. Log in as a staff member with Staff access but without circulate_remaining_permissions.
10. You should not see the 'Holds with cancellation requests: X' line.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Christopher Brannon <cbrannon@cdalibrary.org>
Comment 4 Christopher Brannon 2024-02-10 17:10:40 UTC
Works as described.  However, the link to the cancelled holds page/tab isn't 100%.  It takes you to the page, but doesn't always bring up the tab.  I think it is an issue with the page/tab, not this patch.
Comment 5 Owen Leonard 2024-02-13 12:02:10 UTC
Created attachment 162105 [details] [review]
Bug 36064: (follow-up) Activate correct tab

This patch makes a change to the JavaScript on waitingreserves.pl so
that the correct tab is activated if you follow the "Holds with
cancellation requests" link on the home page.

The page has code to activate the last viewed tab, but I've modified it
so that if there is a location hash ('waitingreserves.pl#tab') the tab
specified in the hash is selected instead of the last used tab.

If there is no location hash the last active tab will be activated.

I've also corrected the location hash in the link on the home page.

To test, apply the patch and follow the "Holds with cancellation
requests" link. The "Holds with cancellation requests" tab should be
active.

Click a different tab, e.g. "Holds waiting." Go the the circulation home
page, then click the link for "Holds awaiting pickup." The tab you
selected should be active.