Attachment 173223 Details for Bug 38240 – Bug 38240: Do not hide columns if no items to display

[patch] Bug 38240: Do not hide columns if no items to display

Bug-38240-Do-not-hide-columns-if-no-items-to-displ.patch (text/plain), 1.94 KB, created by Pedro Amorim on 2024-10-23 14:55:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pedro Amorim

Created: 2024-10-23 14:55:30 UTC

Size: 1.94 KB

patch

obsolete

>From 3ef2b6035629a445737a52c8436911696a62b897 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 23 Oct 2024 15:34:09 +0200
>Subject: [PATCH] Bug 38240: Do not hide columns if no items to display
>
>If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again.
>
>Test plan:
>http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4
>All items are from CPL
>Select another library
>=> No items displayed
>Without this patch the headers are hidden and it's impossible to modify
>the filters
>With this patch the columns that were displayed on the last draw are
>still there, letting you modify the filters
>
>Of course there might have other problematic situations.
>Say you have a lot of items, and you filter on a column that will lead
>to display some items without data for this column, the filter will be
>hidden and there will be no way to show it again.
>
>Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
>---
> .../includes/html_helpers/tables/items/catalogue_detail.inc   | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 80275247ba..58bb591f9d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -836,7 +836,9 @@
>                     });
>                 [% END %]
> 
>-                update_columns_visibility(settings);
>+                if ( api.data().length ) {
>+                    update_columns_visibility(settings);
>+                }
> 
>                 if ( drawcallback ) { drawcallback(this); }
>             },
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38240: 173217 | 173223 | 173246 | 173253