If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again.
Created attachment 173217 [details] [review] Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again.
Created attachment 173223 [details] [review] Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
(In reply to Jonathan Druart from comment #1) > Of course there might have other problematic situations. > Say you have a lot of items, and you filter on a column that will lead > to display some items without data for this column, the filter will be > hidden and there will be no way to show it again. Are you able to provide instructions to reproduce this?
Created attachment 173246 [details] [review] Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Of course there might have other problematic situations. Say you have a lot of items, and you filter on a column that will lead to display some items without data for this column, the filter will be hidden and there will be no way to show it again. Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Not quite as dire as "impossible to modify" - just click Hide filters and then Show filters. Certainly "annoying to modify" though, especially if you've already set several other filters.
(In reply to Pedro Amorim from comment #3) > (In reply to Jonathan Druart from comment #1) > > Of course there might have other problematic situations. > > Say you have a lot of items, and you filter on a column that will lead > > to display some items without data for this column, the filter will be > > hidden and there will be no way to show it again. > > Are you able to provide instructions to reproduce this? No, actually that didn't make sense. If you select a value there will be data. I was typing the commit message with what came to mind it seems... I will remove this part from the commit message. (In reply to Phil Ringnalda from comment #5) > Not quite as dire as "impossible to modify" - just click Hide filters and > then Show filters. Certainly "annoying to modify" though, especially if > you've already set several other filters. Yes ofc, but then you are loosing the state of the table. Thanks you both for the signoff!
Created attachment 173253 [details] [review] Bug 38240: Do not hide columns if no items to display If you filter items using the column filters and that no item are displayed, all columns will be hidden (because no data for those columns) and it is then impossible to reset the filters show items again. Test plan: http://localhost:8081/cgi-bin/koha/catalogue/detail.pl?biblionumber=4 All items are from CPL Select another library => No items displayed Without this patch the headers are hidden and it's impossible to modify the filters With this patch the columns that were displayed on the last draw are still there, letting you modify the filters Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Phil Ringnalda <phil@chetcolibrary.org>
Converting this to PQA.
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.x for upcoming 24.05.06