Bugzilla – Attachment 173508 Details for
Bug 38138
Main contact method in hold pop-up untranslatable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method
Bug-38138-bug-33398-follow-up-Dont-display-code-fo.patch (text/plain), 3.38 KB, created by
Martin Renvoize (ashimema)
on 2024-10-28 10:50:49 UTC
(
hide
)
Description:
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2024-10-28 10:50:49 UTC
Size:
3.38 KB
patch
obsolete
>From 03f6a8652c7454faedcc14b9bcbef6c3562aae51 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 16 Oct 2024 10:28:47 +0200 >Subject: [PATCH] Bug 38138: (bug 33398 follow-up) Don't display code for > primary contact method > >We have several choices for "primary_contact_method", we don't want to >display the code but the label >phone => Primary phone >phonepro => Secondary phone >mobile => Other phone >email => Primary email >emailpro => Secondary email >fax => Fax > >Bonus: it will make it translatable. > >Test plan: >1. Edit a patron record to add a Main contact method >2. Place a hold for this patron >3. Check the item in > --> Pop up says "Main contact method:" followed by the choice. > >Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > .../prog/en/modules/circ/returns.tt | 17 ++++++++++++++++- > 1 file changed, 16 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index b3812072cc2..da0cb8b0dbe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -856,7 +856,22 @@ > [% UNLESS ( transfertodo) %] > [% INCLUDE display_bormessagepref %] > [% IF patron.primary_contact_method %] >- <li id="main_contact_method">Main contact method: <span>[% patron.primary_contact_method | html %]</span></li> >+ <li id="main_contact_method">Main contact method: >+ [% SWITCH patron.primary_contact_method %] >+ [% CASE 'phone' %] >+ <span>Primary phone</span> >+ [% CASE 'phonepro' %] >+ <span>Secondary phone</span> >+ [% CASE 'mobile' %] >+ <span>Other phone</span> >+ [% CASE 'email' %] >+ <span>Primary email</span> >+ [% CASE 'emailpro' %] >+ <span>Secondary email</span> >+ [% CASE 'fax' %] >+ <span>Fax</span> >+ [% END %] >+ </li> > [% END %] > [% END %] > >-- >2.47.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38138
:
172805
|
172819
| 173508