Bug 38138 - Main contact method in hold pop-up untranslatable
Summary: Main contact method in hold pop-up untranslatable
Status: RESOLVED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Martin Renvoize (ashimema)
URL:
Keywords:
Depends on: 33398
Blocks:
  Show dependency treegraph
 
Reported: 2024-10-10 15:14 UTC by Caroline Cyr La Rose
Modified: 2025-02-03 16:47 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
24.11.00,24.05.06,23.11.11
Circulation function:


Attachments
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method (3.25 KB, patch)
2024-10-16 08:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method (3.32 KB, patch)
2024-10-16 13:11 UTC, Caroline Cyr La Rose
Details | Diff | Splinter Review
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method (3.38 KB, patch)
2024-10-28 10:50 UTC, Martin Renvoize (ashimema)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Caroline Cyr La Rose 2024-10-10 15:14:35 UTC
The main contact method shown in the hold pop-up (added in Bug 33398) is untranslatable.

To get there:
1. Edit a patron record to add a Main contact method
2. Place a hold for this patron
3. Check the item in
   --> Pop up says "Main contact method:" followed by the choice. The choice is what is not translatable.

I also think that in English, the choice displayed should match the one in the dropdown in the patron edit form.

phone => Primary phone
phonepro => Secondary phone
mobile => Other phone
email => Primary email
emailpro => Secondary email
fax => Fax
Comment 1 Jonathan Druart 2024-10-16 08:30:52 UTC
Created attachment 172805 [details] [review]
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method

We have several choices for "primary_contact_method", we don't want to
display the code but the label
phone => Primary phone
phonepro => Secondary phone
mobile => Other phone
email => Primary email
emailpro => Secondary email
fax => Fax

Bonus: it will make it translatable.

Test plan:
1. Edit a patron record to add a Main contact method
2. Place a hold for this patron
3. Check the item in
   --> Pop up says "Main contact method:" followed by the choice.
Comment 2 Caroline Cyr La Rose 2024-10-16 13:11:12 UTC
Created attachment 172819 [details] [review]
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method

We have several choices for "primary_contact_method", we don't want to
display the code but the label
phone => Primary phone
phonepro => Secondary phone
mobile => Other phone
email => Primary email
emailpro => Secondary email
fax => Fax

Bonus: it will make it translatable.

Test plan:
1. Edit a patron record to add a Main contact method
2. Place a hold for this patron
3. Check the item in
   --> Pop up says "Main contact method:" followed by the choice.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Comment 3 Caroline Cyr La Rose 2024-10-16 13:11:27 UTC
Merci Jonathan!!
Comment 4 Martin Renvoize (ashimema) 2024-10-28 10:50:49 UTC
Created attachment 173508 [details] [review]
Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method

We have several choices for "primary_contact_method", we don't want to
display the code but the label
phone => Primary phone
phonepro => Secondary phone
mobile => Other phone
email => Primary email
emailpro => Secondary email
fax => Fax

Bonus: it will make it translatable.

Test plan:
1. Edit a patron record to add a Main contact method
2. Place a hold for this patron
3. Check the item in
   --> Pop up says "Main contact method:" followed by the choice.

Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Comment 5 Katrin Fischer 2024-10-29 07:54:34 UTC
Pushed for 24.11!

Well done everyone, thank you!
Comment 6 Lucas Gass (lukeg) 2024-11-22 21:25:33 UTC
Backported to 24.05.06
Comment 7 Fridolin Somers 2024-12-13 15:27:03 UTC
Pushed to 23.11.x for 23.11.11
Comment 8 Jesse Maseto 2025-02-03 16:47:26 UTC
Not pushed to LTS. Marked Resolved.

If you feel this should be in LTS please reply with your reason.