The main contact method shown in the hold pop-up (added in Bug 33398) is untranslatable. To get there: 1. Edit a patron record to add a Main contact method 2. Place a hold for this patron 3. Check the item in --> Pop up says "Main contact method:" followed by the choice. The choice is what is not translatable. I also think that in English, the choice displayed should match the one in the dropdown in the patron edit form. phone => Primary phone phonepro => Secondary phone mobile => Other phone email => Primary email emailpro => Secondary email fax => Fax
Created attachment 172805 [details] [review] Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method We have several choices for "primary_contact_method", we don't want to display the code but the label phone => Primary phone phonepro => Secondary phone mobile => Other phone email => Primary email emailpro => Secondary email fax => Fax Bonus: it will make it translatable. Test plan: 1. Edit a patron record to add a Main contact method 2. Place a hold for this patron 3. Check the item in --> Pop up says "Main contact method:" followed by the choice.
Created attachment 172819 [details] [review] Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method We have several choices for "primary_contact_method", we don't want to display the code but the label phone => Primary phone phonepro => Secondary phone mobile => Other phone email => Primary email emailpro => Secondary email fax => Fax Bonus: it will make it translatable. Test plan: 1. Edit a patron record to add a Main contact method 2. Place a hold for this patron 3. Check the item in --> Pop up says "Main contact method:" followed by the choice. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com>
Merci Jonathan!!
Created attachment 173508 [details] [review] Bug 38138: (bug 33398 follow-up) Don't display code for primary contact method We have several choices for "primary_contact_method", we don't want to display the code but the label phone => Primary phone phonepro => Secondary phone mobile => Other phone email => Primary email emailpro => Secondary email fax => Fax Bonus: it will make it translatable. Test plan: 1. Edit a patron record to add a Main contact method 2. Place a hold for this patron 3. Check the item in --> Pop up says "Main contact method:" followed by the choice. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Pushed for 24.11! Well done everyone, thank you!
Backported to 24.05.06
Pushed to 23.11.x for 23.11.11
Not pushed to LTS. Marked Resolved. If you feel this should be in LTS please reply with your reason.