Attachment 17354 Details for Bug 10027 – Bug 10027 - Fine details not showing when printing a fine

[patch] Bug 10027 - Fine details not showing when printing a fine

Bug-10027---Fine-details-not-showing-when-printing.patch (text/plain), 1.38 KB, created by Chris Cormack on 2013-04-10 23:44:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2013-04-10 23:44:59 UTC

Size: 1.38 KB

patch

obsolete

>From 8f54b390842f05f23900dda99aa423ffa310e572 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 10 Apr 2013 13:45:18 -0400
>Subject: [PATCH] Bug 10027 - Fine details not showing when printing a fine
>
>Previously printing a fine invoice would result in a page with both the
>single item charge and the total outstanding dues. Right now only the
>total outstanding is printed.
>
>Test Plan:
>1) Print a fine, note the fine doesn't show, only the total
>2) Apply patch
>3) Print a fine, not the fine does show
>
>Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
>---
> members/printinvoice.pl |    3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>diff --git a/members/printinvoice.pl b/members/printinvoice.pl
>index 3e04fcc..9e69fb7 100755
>--- a/members/printinvoice.pl
>+++ b/members/printinvoice.pl
>@@ -47,7 +47,6 @@ my ($template, $loggedinuser, $cookie)
> 
> my $borrowernumber=$input->param('borrowernumber');
> my $action = $input->param('action') || '';
>-my $accountno = $input->param('accountno');
> my $accountlines_id = $input->param('accountlines_id');
> 
> #get borrower details
>@@ -74,7 +73,7 @@ my @accountrows; # this is for the tmpl-loop
> 
> my $toggle;
> for (my $i=0;$i<$numaccts;$i++){
>-   next if ($accts->[$i]{'accountno'} ne $accountno);
>+   next if ($accts->[$i]{'accountlines_id'} ne $accountlines_id );
>     if($i%2){
>             $toggle = 0;
>     } else {
>-- 
>1.7.10.4

Actions: View | Diff | Splinter Review

Attachments on bug 10027: 17348 | 17349 | 17354 | 17355 | 20812 | 20851 | 20852 | 20853