Attachment 173745 Details for Bug 38304 – Bug 38304: Remove SaveState options for OPAC tables

[patch] Bug 38304: Remove SaveState options for OPAC tables

Bug-38304-Remove-SaveState-options-for-OPAC-tables.patch (text/plain), 5.08 KB, created by Aleisha Amohia on 2024-10-31 04:55:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2024-10-31 04:55:45 UTC

Size: 5.08 KB

patch

obsolete

>From 73d53e99d9ec90157afc19667bce132f674773f4 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 30 Oct 2024 16:55:34 +0100
>Subject: [PATCH] Bug 38304: Remove SaveState options for OPAC tables
>
>On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC
>
>  Save configuration state on page change:
>  Save search state on page change:
>
>We could remove those options for those tables to remove ambiguity.
>
>Test plan:
>Go the the table settings and open the "OPAC" tab.
>Notice that the options are no longer displayed (but they are still for
>the other tabs)
>Modify some settings
>Save and confirm the settings have been correctly saved.
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
>---
> .../prog/en/modules/admin/columns_settings.tt | 38 ++++++++++---------
> 1 file changed, 20 insertions(+), 18 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>index 8bf0b32d448..171a27bc59e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/columns_settings.tt
>@@ -149,25 +149,27 @@
>                                     </p>
>                                 [% END %]
> 
>-                                <p>
>-                                    [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %]
>-                                    <label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label>
>-                                    [%- IF table_settings.default_save_state -%]
>-                                        <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
>-                                    [%- ELSE -%]
>-                                        <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
>-                                    [%- END -%]
>-                                </p>
>+                                [% IF modulename != 'opac' %]
>+                                    <p>
>+                                        [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state" %]
>+                                        <label for="[% option_name | html %]" title="Save the column visibility, length of the table and order in session">Save configuration state on page change:</label>
>+                                        [%- IF table_settings.default_save_state -%]
>+                                            <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
>+                                        [%- ELSE -%]
>+                                            <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
>+                                        [%- END -%]
>+                                    </p>
> 
>-                                <p>
>-                                    [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %]
>-                                    <label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label>
>-                                    [%- IF table_settings.default_save_state_search -%]
>-                                        <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
>-                                    [%- ELSE -%]
>-                                        <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
>-                                    [%- END -%]
>-                                </p>
>+                                    <p>
>+                                        [% SET option_name = pagename _ "|" _ tablename _ "_default_save_state_search" %]
>+                                        <label for="[% option_name | html %]" title="Save the search and filtering in session">Save search state on page change:</label>
>+                                        [%- IF table_settings.default_save_state_search -%]
>+                                            <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" checked="checked" />
>+                                        [%- ELSE -%]
>+                                            <input type="checkbox" id="[% option_name | html %]" name="[% option_name | html %]" value="1" />
>+                                        [%- END -%]
>+                                    </p>
>+                                [% END %]
> 
>                             </div>
>                         [% END %]
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 38304: 173723 | 173731 | 173745