Bug 38304 - Remove SaveState options for OPAC tables
Summary: Remove SaveState options for OPAC tables
Status: Pushed to main
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: unspecified
Hardware: All All
: P5 - low normal
Assignee: Jonathan Druart
QA Contact: Aleisha Amohia
URL:
Keywords:
Depends on: 33484
Blocks: 37238
  Show dependency tree / graph
 
Reported: 2024-10-30 15:53 UTC by Jonathan Druart
Modified: 2024-10-31 10:04 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
This removes the "SaveState" options (Save configuration state on page change, Save search state on page change) from the OPAC table settings configuration. The new SaveState feature (added to 24.11 by bug 33484) is not implemented for the OPAC tables, and this removes any ambiguity.
Version(s) released in:
24.11.00
Circulation function:

Attachments
Bug 38304: Remove SaveState options for OPAC tables (4.97 KB, patch)
2024-10-30 15:56 UTC, Jonathan Druart 		Details | Diff | Splinter Review
Bug 38304: Remove SaveState options for OPAC tables (5.02 KB, patch)
2024-10-30 17:47 UTC, David Nind 		Details | Diff | Splinter Review
Bug 38304: Remove SaveState options for OPAC tables (5.08 KB, patch)
2024-10-31 04:55 UTC, Aleisha Amohia 		Details | Diff | Splinter Review
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2024-10-30 15:53:15 UTC 
On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC

  Save configuration state on page change:
  Save search state on page change: 

We could remove those options for those tables to remove ambiguity.
Comment 1 Jonathan Druart 2024-10-30 15:56:52 UTC 
Created attachment 173723 [details] [review]
Bug 38304: Remove SaveState options for OPAC tables

On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC

  Save configuration state on page change:
  Save search state on page change:

We could remove those options for those tables to remove ambiguity.

Test plan:
Go the the table settings and open the "OPAC" tab.
Notice that the options are no longer displayed (but they are still for
the other tabs)
Modify some settings
Save and confirm the settings have been correctly saved.
Comment 2 David Nind 2024-10-30 17:47:23 UTC 
Created attachment 173731 [details] [review]
Bug 38304: Remove SaveState options for OPAC tables

On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC

  Save configuration state on page change:
  Save search state on page change:

We could remove those options for those tables to remove ambiguity.

Test plan:
Go the the table settings and open the "OPAC" tab.
Notice that the options are no longer displayed (but they are still for
the other tabs)
Modify some settings
Save and confirm the settings have been correctly saved.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Aleisha Amohia 2024-10-31 04:55:45 UTC 
Created attachment 173745 [details] [review]
Bug 38304: Remove SaveState options for OPAC tables

On /admin/columns_settings.pl you can select the two options related to SaveState for the OPAC tables, but those tables do not show the filters and column filters. Also the work on bug 33484 is not implemented at the OPAC

  Save configuration state on page change:
  Save search state on page change:

We could remove those options for those tables to remove ambiguity.

Test plan:
Go the the table settings and open the "OPAC" tab.
Notice that the options are no longer displayed (but they are still for
the other tabs)
Modify some settings
Save and confirm the settings have been correctly saved.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com>
Comment 4 Katrin Fischer 2024-10-31 10:04:19 UTC 
Pushed for 24.11!

Well done everyone, thank you!