Bugzilla – Attachment 173802 Details for
Bug 35947
Accounting transactions do not show managing librarian if HidePatronName is set to yes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status
Bug-35947-Show-managing-librarian-in-accounting-tr.patch (text/plain), 4.26 KB, created by
ByWater Sandboxes
on 2024-10-31 14:27:47 UTC
(
hide
)
Description:
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status
Filename:
MIME Type:
Creator:
ByWater Sandboxes
Created:
2024-10-31 14:27:47 UTC
Size:
4.26 KB
patch
obsolete
>From 3f0f68d3d45738cd0b728f3846c2db3b63756fb9 Mon Sep 17 00:00:00 2001 >From: Sam Lau <samalau@gmail.com> >Date: Wed, 12 Jun 2024 18:28:25 +0000 >Subject: [PATCH] Bug 35947: Show managing librarian in accounting transaction > regardless of HidePatronName status > >This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc' > >1) Set 'HidePatronName' sys. pref. to 'Don't show' >2) Go to a patron's page >3) Click on the accounting tab >4) Select 'Create manual invoice', put in an amount and press save. >5) In the transactions tab, click on the details of that specifc transaction >6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch' >7) Apply patch, restart_all >8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction. >9) Click on this name and make sure the link works >10) Go back to accounting section and now make a payment. >11) View details of this transaction and ensure the librarian is present > >Signed-off-by: Laura ONeil <laura@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc | 4 ++-- > .../prog/en/modules/members/accountline-details.tt | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >index a633697a59..20909154cb 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc >@@ -55,7 +55,7 @@ > [%- SET display_patron_name = 0 -%] > [%- END -%] > [%- END -%] >-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] >+[%- IF ( display_patron_name OR display_cardnumber ) -%] > [%- IF link_to == 'circulation_reserves' -%]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#reserves"> > [%- ELSIF link_to == 'circulation_recalls' -%]<a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[%- data.borrowernumber | uri -%]#recalls"> > [%- ELSIF link_to == 'members_pay' -%]<a href="/cgi-bin/koha/members/pay.pl?borrowernumber=[%- patron.borrowernumber | uri -%]"> >@@ -79,6 +79,6 @@ > <span>A patron from library [%- Branches.GetName( patron.branchcode ) | html -%]</span> > [%- END -%] > >-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%] >+[%- IF ( display_patron_name OR display_cardnumber ) -%] > </a> > [%- END -%] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >index b1061728a0..c5115c0a0c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/accountline-details.tt >@@ -145,7 +145,7 @@ > </td> > <td> > [% IF accountline.manager_id %] >- [% INCLUDE 'patron-title.inc' patron => accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] >+ [% INCLUDE 'patron-title.inc' patron => accountline.manager, no_cardnumber => 1 %] > [% END %] > </td> > </tr> >@@ -208,7 +208,7 @@ > </td> > <td> > [% IF offset_accountline.manager_id %] >- [% INCLUDE 'patron-title.inc' patron => offset_accountline.manager, hide_patron_infos_if_needed => 1, no_cardnumber => 1 %] >+ [% INCLUDE 'patron-title.inc' patron => offset_accountline.manager, no_cardnumber => 1 %] > [% END %] > </td> > [%- ELSE -%] >-- >2.39.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 35947
:
167673
| 173802