Bug 35947 - Accounting transactions do not show managing librarian if HidePatronName is set to yes
Summary: Accounting transactions do not show managing librarian if HidePatronName is s...
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low minor
Assignee: Lucas Gass (lukeg)
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2024-01-30 14:23 UTC by Kelly McElligott
Modified: 2025-06-26 15:31 UTC (History)
6 users (show)

See Also:
GIT URL:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status (4.21 KB, patch)
2024-06-12 18:40 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status (4.26 KB, patch)
2024-10-31 14:27 UTC, ByWater Sandboxes
Details | Diff | Splinter Review
Bug 35947: Show account manager info regardless of HidePatronName pref (2.99 KB, patch)
2025-06-25 16:28 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35947: Show account manager info regardless of HidePatronName pref (3.65 KB, patch)
2025-06-25 16:29 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 35947: Show account manager info regardless of HidePatronName pref (3.71 KB, patch)
2025-06-26 15:31 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2024-01-30 14:23:47 UTC
A new bug 34377: Accounting transactions should show managing librarian info for credits/debits, allows librarians to see the librarian who did the accounting transaction.  However, if the system preference, hidepatronname is set to Show, the name of the person is not shown, it says "a patron from X branch". This does not seem helpful nor connected to the hidepatronname system preference description, "Show/Don't Show the names of patrons that have items checked out or on hold on detail pages or the "Place Hold" screen." As this is not the checked out screen or the place hold screen.
Comment 1 Kelly McElligott 2024-01-30 14:32:09 UTC
Sorry, I meant if the library has the system preference, HidePatronName, set to Don't Show. ^^
Comment 2 Sam Lau 2024-06-12 18:40:43 UTC Comment hidden (obsolete)
Comment 3 ByWater Sandboxes 2024-10-31 14:27:47 UTC
Created attachment 173802 [details] [review]
Bug 35947: Show managing librarian in accounting transaction regardless of HidePatronName status

This patch removes the 'hide_patron_infos_if_needed => 1' passing into 'patron-title.inc' from 'accountline-details.tt'. Doing so allows for the managing librarian to be shown in the accounting details. In order to correctly link to this librarian, necessary changes were also made to the 'patron-title.inc'

1) Set 'HidePatronName' sys. pref. to 'Don't show'
2) Go to a patron's page
3) Click on the accounting tab
4) Select 'Create manual invoice', put in an amount and press save.
5) In the transactions tab, click on the details of that specifc transaction
6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch'
7) Apply patch, restart_all
8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction.
9) Click on this name and make sure the link works
10) Go back to accounting section and now make a payment.
11) View details of this transaction and ensure the librarian is present

Signed-off-by: Laura ONeil <laura@bywatersolutions.com>
Comment 4 Marcel de Rooy 2024-11-15 10:54:51 UTC
-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%]
+[%- IF ( display_patron_name OR display_cardnumber ) -%]

-[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR display_cardnumber ) -%]
+[%- IF ( display_patron_name OR display_cardnumber ) -%]

Changes in patron-title.inc affect a lot of places. So removing that check here seems wrong. Please prove me wrong.
Comment 5 Lucas Gass (lukeg) 2025-06-25 16:03:43 UTC
(In reply to Marcel de Rooy from comment #4)
> -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR
> display_cardnumber ) -%]
> +[%- IF ( display_patron_name OR display_cardnumber ) -%]
> 
> -[%- IF hide_patron_infos_if_needed AND ( display_patron_name OR
> display_cardnumber ) -%]
> +[%- IF ( display_patron_name OR display_cardnumber ) -%]
> 
> Changes in patron-title.inc affect a lot of places. So removing that check
> here seems wrong. Please prove me wrong.

You're not wrong, it is used in a lot of place. Could we just not use patron-title.inc in this case?
Comment 6 Lucas Gass (lukeg) 2025-06-25 16:28:25 UTC
Created attachment 183515 [details] [review]
Bug 35947: Show account manager info regardless of HidePatronName pref
Comment 7 Lucas Gass (lukeg) 2025-06-25 16:29:03 UTC
Created attachment 183516 [details] [review]
Bug 35947: Show account manager info regardless of HidePatronName pref

1) Set 'HidePatronName' sys. pref. to 'Don't show'
2) Go to a patron's page
3) Click on the accounting tab
4) Select 'Create manual invoice', put in an amount and press save.
5) In the transactions tab, click on the details of that specifc transaction
6) Note that in the "Details of debit" table, the Librarian is set to 'a patron from X branch'
7) Apply patch, restart_all
8) Go to the same transaction, notice that now it says the actual librarian who was in charge of creating transaction.
9) Click on this name and make sure the link works
10) Go back to accounting section and now make a payment.
11) View details of this transaction and ensure the librarian is present
Comment 8 Owen Leonard 2025-06-26 15:31:30 UTC
Created attachment 183550 [details] [review]
Bug 35947: Show account manager info regardless of HidePatronName pref

1) Set 'HidePatronName' sys. pref. to 'Don't show'
2) Go to a patron's page
3) Click on the accounting tab
4) Select 'Create manual invoice', put in an amount and press save.
5) In the transactions tab, click on the details of that specifc
   transaction
6) Note that in the "Details of debit" table, the Librarian is set to 'a
   patron from X branch'
7) Apply patch, restart_all
8) Go to the same transaction, notice that now it says the actual
   librarian who was in charge of creating transaction.
9) Click on this name and make sure the link works
10) Go back to accounting section and now make a payment.
11) View details of this transaction and ensure the librarian is present

Signed-off-by: Owen Leonard <oleonard@myacpl.org>