Attachment 174301 Details for Bug 23674 – Bug 23674: Add ability to add a note to APPLY DISCOUNT

[patch] Bug 23674: Add ability to add a note to APPLY DISCOUNT

Bug-23674-Add-ability-to-add-a-note-to-APPLY-DISCO.patch (text/plain), 3.26 KB, created by Lucas Gass (lukeg) on 2024-11-08 21:38:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-08 21:38:23 UTC

Size: 3.26 KB

patch

obsolete

>From 8acbd4a13aed8048737515d8c34830fe6e60b49a Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Mon, 24 Jun 2024 17:07:47 +0000
>Subject: [PATCH] Bug 23674: Add ability to add a note to APPLY DISCOUNT
>
>To test:
>1. APPLY PATCH and restart_all
>2. Apply a manual invoice to a patron account.
>3. Go to the patron record -> accounting -> transaction tab
>4. Look for the 'Apply discount' button.
>5. When the 'Apply discount' modal appears notcie the 'Note' field.
>6. Add a note, make sure it gets applied to this accountline.
>
>Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
>---
> Koha/Account/Line.pm                                         | 1 +
> .../intranet-tmpl/prog/en/modules/members/boraccount.tt      | 4 ++++
> members/boraccount.pl                                        | 5 ++++-
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
>diff --git a/Koha/Account/Line.pm b/Koha/Account/Line.pm
>index 2dc50293750..516b1fe4614 100644
>--- a/Koha/Account/Line.pm
>+++ b/Koha/Account/Line.pm
>@@ -557,6 +557,7 @@ sub reduce {
>                     borrowernumber    => $self->borrowernumber,
>                     interface         => $params->{interface},
>                     branchcode        => $params->{branch},
>+                    note              => $params->{note},
>                 }
>             )->store();
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>index cb2bc93ccd4..26018cafe2f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/boraccount.tt
>@@ -375,6 +375,10 @@
>                                 <li>
>                                     <span id="charged" class="label">Amount charged: </span><span></span>
>                                 </li>
>+                                <li>
>+                                    <label for="apply_discount_note">Note: </label>
>+                                    <input type="text" id="apply_discount_note" name="apply_discount_note">
>+                                </li>
>                                 <li>
>                                     <label class="required" for="amount">Discount to apply: </label>
>                                     <input type="text" inputmode="numeric" pattern="[0-9]*" id="discount" name="amount" required="required">
>diff --git a/members/boraccount.pl b/members/boraccount.pl
>index 707dc4b2791..e3b85e7e774 100755
>--- a/members/boraccount.pl
>+++ b/members/boraccount.pl
>@@ -161,6 +161,8 @@ if ( $op eq 'cud-discount' ) {
>     my $charge_id        = scalar $input->param('accountlines_id');
>     my $charge           = Koha::Account::Lines->find($charge_id);
>     my $amount           = scalar $input->param('amount');
>+    my $note             = scalar $input->param('apply_discount_note');
>+
>     $schema->txn_do(
>         sub {
> 
>@@ -170,7 +172,8 @@ if ( $op eq 'cud-discount' ) {
>                     branch         => $library_id,
>                     staff_id       => $logged_in_user->id,
>                     interface      => 'intranet',
>-                    amount         => $amount
>+                    amount         => $amount,
>+                    note           => $note,
>                 }
>             );
>         }
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 23674: 168035 | 168036 | 168174 | 168177 | 168178 | 168180 | 168213 | 168329 | 168330 | 169782 | 169783 | 169784 | 169785 | 169786 | 169787 | 169788 | 174300 | 174301 | 174302 | 174303 | 174304 | 174305 | 174306 | 174307 | 174308