Bug 23674 - Allowing notes on all entries in patron Transactions table
Summary: Allowing notes on all entries in patron Transactions table
Status: Signed Off
Alias: None
Product: Koha
Classification: Unclassified
Component: Fines and fees (show other bugs)
Version: Main
Hardware: All All
: P5 - low enhancement
Assignee: Sam Lau
QA Contact: Testopia
URL:
Keywords: Academy, Sandbox
: 22185 24597 (view as bug list)
Depends on:
Blocks: 37211
  Show dependency treegraph
 
Reported: 2019-09-25 00:35 UTC by Kelly McElligott
Modified: 2024-11-22 12:40 UTC (History)
11 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:


Attachments
Bug 23674: Add ability to add a note to APPLY DISCOUNT (3.20 KB, patch)
2024-06-24 17:11 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to pay individual fine from paycollect.tt (2.50 KB, patch)
2024-06-24 17:33 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to pay individual and write-off individual (2.76 KB, patch)
2024-06-26 18:18 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue refund (3.46 KB, patch)
2024-06-26 19:07 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue payout (2.82 KB, patch)
2024-06-26 19:38 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to void payment (7.07 KB, patch)
2024-06-26 20:20 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue refund (3.86 KB, patch)
2024-06-27 19:33 UTC, Sam Lau
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to canceled charge (6.52 KB, patch)
2024-07-01 16:48 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Fix duplicate ID's and label (3.14 KB, patch)
2024-07-01 17:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to APPLY DISCOUNT (3.25 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to pay individual and write-off individual (2.81 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue payout (2.87 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to void payment (7.12 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue refund (3.91 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to canceled charge (6.57 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Fix duplicate ID's and label (3.19 KB, patch)
2024-07-26 19:55 UTC, Roman Dolny
Details | Diff | Splinter Review
Bug 23674: Account for Bootstrap5 changes (4.75 KB, patch)
2024-11-08 21:37 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to APPLY DISCOUNT (3.26 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to pay individual and write-off individual (2.82 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue payout (2.88 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to void payment (7.13 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add a note to issue refund (3.92 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Add ability to add note to canceled charge (6.68 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Fix duplicate ID's and label (3.22 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 23674: Account for Bootstrap5 changes (4.75 KB, patch)
2024-11-08 21:38 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Kelly McElligott 2019-09-25 00:35:13 UTC
It would be nice if a librarian forgot to add a note to a payment/write-off/manual invoice transaction, or if a note was added at time of transaction, that this note is editable.  Currently, this is not something that can be edited, therefore, a librarian would have to remove the entire transaction to edit the note.
Comment 1 Katrin Fischer 2019-09-30 14:12:01 UTC
*** Bug 22185 has been marked as a duplicate of this bug. ***
Comment 2 Andrew Fuerste-Henry 2020-08-26 14:44:33 UTC
Agreed. The Transactions table on boraccount.pl should allow one to add notes and/or edit existing notes.
Comment 3 George Williams (NEKLS) 2021-02-05 17:00:10 UTC
It's not a bad idea, but, as a system administrator for 51 libraries all using 1 shared Koha, I would want some control over who was able to edit notes.

We use custom jQuery to add usernames and branchcodes to all notes so any staff member can easily look at an accountline and know who created it an where so that they don't have to run a report to see, for example, if someone at another library did a writeoff without permission from the library that owns that accountline.  If anyone can edit any note, it makes it possible for someone to edit out the history of any undeserved writeoffs or credits they've created.

I would want to be able to control who can edit the accountlines notes.  A staff permission would be preferable, but a system preference would work too.
Comment 4 Andrew Fuerste-Henry 2022-01-20 13:37:37 UTC
Changed the bug title to reflect a broadened scope. Every accountlines entry has a notes field, so why not just put an Edit Note option on every line in the Transactions table.

As George says, we'd want access to that button to be tied to a specific permission.
Comment 5 Wally DesChamps 2023-10-09 17:53:27 UTC
Yes.  Ability to add and edit notes is needed.  Ability to extend "permissions" to that module for making/editing notes (and/or like in the Messages on patron's accounts where it gives the librarian, date, and time for the message when entered or edited) would be excellent, too [especially for the big wigs, like George ;-)]
Comment 6 Lucas Gass (lukeg) 2024-06-24 17:11:27 UTC
Created attachment 168035 [details] [review]
Bug 23674: Add ability to add a note to APPLY DISCOUNT

To test:
1. APPLY PATCH and restart_all
2. Apply a manual invoice to a patron account.
3. Go to the patron record -> accounting -> transaction tab
4. Look for the 'Apply discount' button.
5. When the 'Apply discount' modal appears notcie the 'Note' field.
6. Add a note, make sure it gets applied to this accountline.
Comment 7 Lucas Gass (lukeg) 2024-06-24 17:33:36 UTC Comment hidden (obsolete)
Comment 8 Lucas Gass (lukeg) 2024-06-26 17:25:52 UTC
Place where we need to have the ability to add a note:

Pay individual 
Write-off individual 
Void
Issue refund
Issue payout
Apply discount
Comment 9 Sam Lau 2024-06-26 18:18:40 UTC
Created attachment 168174 [details] [review]
Bug 23674: Add ability to add a note to pay individual and write-off individual

To test:
1) Apply manual invoice to a patron account
2) Go to the patron record -> accounting -> transaction tab
3) Look for the "Pay" button under the actions column. Click this
4) Notice no place to enter note
5) Click the "Write off" button. Notice there is no place to enter note
6) Apply patch, restart_all
7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs.
8) Write a not in the pay tab and confirm. Make sure this not shows up in the table.
9) Add another invoice and then test the note functionallity for the write-offs.
Comment 10 Sam Lau 2024-06-26 19:07:58 UTC
Created attachment 168177 [details] [review]
Bug 23674: Add ability to add a note to issue refund
Comment 11 Sam Lau 2024-06-26 19:38:18 UTC
Created attachment 168178 [details] [review]
Bug 23674: Add ability to add a note to issue payout

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
3) Under the actions column, select 'Issue Payout'
4) You can now enter a note. Type something in and press confirm.
5) Ensure the note shows up in the note column.
Comment 12 Sam Lau 2024-06-26 20:20:50 UTC
Created attachment 168180 [details] [review]
Bug 23674: Add ability to add note to void payment

To test:
1) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
2) Under the actions column, select "Void"
3) Notice no option for a note. Press cancel
4) Apply patch, restart_all
5) Press void again. This time, you should see a modal that gives you the option to type in a note.
6) Type something in and select submit.
7) Ensure the note shows up in the note column.
Comment 13 Lucas Gass (lukeg) 2024-06-27 14:38:55 UTC
*** Bug 24597 has been marked as a duplicate of this bug. ***
Comment 14 Sam Lau 2024-06-27 19:33:45 UTC
Created attachment 168213 [details] [review]
Bug 23674: Add ability to add a note to issue refund

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm.
3) In the transactions tab, for the invoice you just created, under the actions column select issue refund.
4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm.
5) Ensure the note correctly shows in the table.
Comment 15 Lucas Gass (lukeg) 2024-07-01 16:48:06 UTC
Created attachment 168329 [details] [review]
Bug 23674: Add ability to add note to canceled charge

To test, with this patchset applied:
1) From patron accounting page -> Add a manual invoice
2) Under the transaction tab click 'Cancel charge'
3) You should see a modal that gives you the option to type in a note.
4) Type something in and select submit.
5) Ensure the note shows up in the note column.
Comment 16 Lucas Gass (lukeg) 2024-07-01 17:15:24 UTC
Created attachment 168330 [details] [review]
Bug 23674: Fix duplicate ID's and label
Comment 17 Roman Dolny 2024-07-26 19:55:04 UTC
Created attachment 169782 [details] [review]
Bug 23674: Add ability to add a note to APPLY DISCOUNT

To test:
1. APPLY PATCH and restart_all
2. Apply a manual invoice to a patron account.
3. Go to the patron record -> accounting -> transaction tab
4. Look for the 'Apply discount' button.
5. When the 'Apply discount' modal appears notcie the 'Note' field.
6. Add a note, make sure it gets applied to this accountline.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 18 Roman Dolny 2024-07-26 19:55:07 UTC
Created attachment 169783 [details] [review]
Bug 23674: Add ability to add a note to pay individual and write-off individual

To test:
1) Apply manual invoice to a patron account
2) Go to the patron record -> accounting -> transaction tab
3) Look for the "Pay" button under the actions column. Click this
4) Notice no place to enter note
5) Click the "Write off" button. Notice there is no place to enter note
6) Apply patch, restart_all
7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs.
8) Write a not in the pay tab and confirm. Make sure this not shows up in the table.
9) Add another invoice and then test the note functionallity for the write-offs.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 19 Roman Dolny 2024-07-26 19:55:10 UTC
Created attachment 169784 [details] [review]
Bug 23674: Add ability to add a note to issue payout

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
3) Under the actions column, select 'Issue Payout'
4) You can now enter a note. Type something in and press confirm.
5) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 20 Roman Dolny 2024-07-26 19:55:13 UTC
Created attachment 169785 [details] [review]
Bug 23674: Add ability to add note to void payment

To test:
1) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
2) Under the actions column, select "Void"
3) Notice no option for a note. Press cancel
4) Apply patch, restart_all
5) Press void again. This time, you should see a modal that gives you the option to type in a note.
6) Type something in and select submit.
7) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 21 Roman Dolny 2024-07-26 19:55:16 UTC
Created attachment 169786 [details] [review]
Bug 23674: Add ability to add a note to issue refund

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm.
3) In the transactions tab, for the invoice you just created, under the actions column select issue refund.
4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm.
5) Ensure the note correctly shows in the table.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 22 Roman Dolny 2024-07-26 19:55:19 UTC
Created attachment 169787 [details] [review]
Bug 23674: Add ability to add note to canceled charge

To test, with this patchset applied:
1) From patron accounting page -> Add a manual invoice
2) Under the transaction tab click 'Cancel charge'
3) You should see a modal that gives you the option to type in a note.
4) Type something in and select submit.
5) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 23 Roman Dolny 2024-07-26 19:55:22 UTC
Created attachment 169788 [details] [review]
Bug 23674: Fix duplicate ID's and label

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 24 Roman Dolny 2024-07-26 19:59:22 UTC
Test notes:

Test for "Bug 23674: Add ability to add a note to issue payout" works as described at the end, with full patchset.

QA script:
WARN   members/boraccount.pl
  WARN   tidiness
    The file is less tidy than before (bad/messy lines before: 45, now: 46)
WARN   members/cancel-charge.pl
  WARN   tidiness
    The file is less tidy than before (bad/messy lines before: 4, now: 6)
Comment 25 Lucas Gass (lukeg) 2024-11-08 21:35:46 UTC
Patch no longer applies due to Bootstrap 5 changes
Comment 26 Lucas Gass (lukeg) 2024-11-08 21:37:45 UTC
Created attachment 174300 [details] [review]
Bug 23674: Account for Bootstrap5 changes
Comment 27 Lucas Gass (lukeg) 2024-11-08 21:38:23 UTC
Created attachment 174301 [details] [review]
Bug 23674: Add ability to add a note to APPLY DISCOUNT

To test:
1. APPLY PATCH and restart_all
2. Apply a manual invoice to a patron account.
3. Go to the patron record -> accounting -> transaction tab
4. Look for the 'Apply discount' button.
5. When the 'Apply discount' modal appears notcie the 'Note' field.
6. Add a note, make sure it gets applied to this accountline.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 28 Lucas Gass (lukeg) 2024-11-08 21:38:26 UTC
Created attachment 174302 [details] [review]
Bug 23674: Add ability to add a note to pay individual and write-off individual

To test:
1) Apply manual invoice to a patron account
2) Go to the patron record -> accounting -> transaction tab
3) Look for the "Pay" button under the actions column. Click this
4) Notice no place to enter note
5) Click the "Write off" button. Notice there is no place to enter note
6) Apply patch, restart_all
7) Notice that a "Note: " input appears in both the 'Pay' and 'Write off' tabs.
8) Write a not in the pay tab and confirm. Make sure this not shows up in the table.
9) Add another invoice and then test the note functionallity for the write-offs.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 29 Lucas Gass (lukeg) 2024-11-08 21:38:30 UTC
Created attachment 174303 [details] [review]
Bug 23674: Add ability to add a note to issue payout

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
3) Under the actions column, select 'Issue Payout'
4) You can now enter a note. Type something in and press confirm.
5) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 30 Lucas Gass (lukeg) 2024-11-08 21:38:33 UTC
Created attachment 174304 [details] [review]
Bug 23674: Add ability to add note to void payment

To test:
1) From patron accounting page -> Create manual credit. Put in some amount and press add credit.
2) Under the actions column, select "Void"
3) Notice no option for a note. Press cancel
4) Apply patch, restart_all
5) Press void again. This time, you should see a modal that gives you the option to type in a note.
6) Type something in and select submit.
7) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 31 Lucas Gass (lukeg) 2024-11-08 21:38:36 UTC
Created attachment 174305 [details] [review]
Bug 23674: Add ability to add a note to issue refund

To test:
1) Apply patch, restart_all
2) From patron accounting page -> Create manual invoice. Enter some amount and select save and pay. Press confirm.
3) In the transactions tab, for the invoice you just created, under the actions column select issue refund.
4) This should open a modal with the ability to enter a note for the refund. Type in a note and confirm.
5) Ensure the note correctly shows in the table.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 32 Lucas Gass (lukeg) 2024-11-08 21:38:39 UTC
Created attachment 174306 [details] [review]
Bug 23674: Add ability to add note to canceled charge

To test, with this patchset applied:
1) From patron accounting page -> Add a manual invoice
2) Under the transaction tab click 'Cancel charge'
3) You should see a modal that gives you the option to type in a note.
4) Type something in and select submit.
5) Ensure the note shows up in the note column.

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 33 Lucas Gass (lukeg) 2024-11-08 21:38:42 UTC
Created attachment 174307 [details] [review]
Bug 23674: Fix duplicate ID's and label

Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl>
Comment 34 Lucas Gass (lukeg) 2024-11-08 21:38:45 UTC
Created attachment 174308 [details] [review]
Bug 23674: Account for Bootstrap5 changes