Bugzilla – Attachment 174886 Details for
Bug 38343
False display of closed invoices in receive process
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 38343: Add info if there are closed invoices not displayed
Bug-38343-Add-info-if-there-are-closed-invoices-no.patch (text/plain), 2.13 KB, created by
Jonathan Druart
on 2024-11-21 14:35:21 UTC
(
hide
)
Description:
Bug 38343: Add info if there are closed invoices not displayed
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2024-11-21 14:35:21 UTC
Size:
2.13 KB
patch
obsolete
>From 3d6097b23ede8753e35a11fe69fa65db8847b470 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 21 Nov 2024 15:35:00 +0100 >Subject: [PATCH] Bug 38343: Add info if there are closed invoices not > displayed > >--- > acqui/parcels.pl | 14 ++++++++++++++ > .../intranet-tmpl/prog/en/modules/acqui/parcels.tt | 4 ++++ > 2 files changed, 18 insertions(+) > >diff --git a/acqui/parcels.pl b/acqui/parcels.pl >index 23baa663f36..fa7c6173209 100755 >--- a/acqui/parcels.pl >+++ b/acqui/parcels.pl >@@ -161,6 +161,20 @@ my @parcels = GetInvoices( > ); > my $count_parcels = @parcels; > >+unless ($include_closed) { >+ >+ # FIXME Implement and use Koha::Acquisition::Bookseller->invoices; >+ my $closed_invoices = Koha::Acquisition::Invoices->search( >+ { >+ booksellerid => $booksellerid, >+ ( $datefrom ? ( shipmentdatefrom => $datefrom ) : () ), >+ ( $dateto ? ( shipmentdateto => $dateto ) : () ), >+ closedate => { '!=' => undef }, >+ } >+ ); >+ $template->param( closed_invoices => $closed_invoices->count ); >+} >+ > # multi page display gestion > $startfrom ||= 0; > if ( $count_parcels > $resultsperpage ) { >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >index e8698d49b21..2501b191fb5 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/parcels.tt >@@ -39,6 +39,10 @@ > [% INCLUDE 'messages.inc' %] > <h1>Receive shipment from vendor <a href="/cgi-bin/koha/acqui/supplier.pl?booksellerid=[% booksellerid | uri %]">[% name | html %]</a></h1> > >+ [% IF closed_invoices %] >+ <p>[% I18N.tnx("There is one closed invoice not included in this search.", "There are {closed_invoices} closed invoices not included in this search.", closed_invoices, { closed_invoices => closed_invoices }) %]</p> >+ [% END %] >+ > [% IF ( error_failed_to_create_invoice ) %] > <div id="error" class="alert alert-warning"> > <p>An error has occurred. Invoice cannot be created.</p> >-- >2.34.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 38343
:
174818
|
174820
|
174844
|
174845
|
174846
|
174847
|
174848
| 174886