acquisition module > bookseller > receive shipments All closed invoices are displayed
When we receive an invoice from a vendor we don't want to see already closed invoices. Closed invoices means you can't receive orders anymore. So they have no value on the receive page. Because of the list of all invoices (including the closed ones) of a vendor you always have to scroll down to enter the invoice number to create a new invoice. To recreate step by step: 1.) go to acquisition module and search for a vendor 2.) click on button 'receive shipment' 3.) enter an invoice number and click 'next' 4.) click on button 'finish receiving' 5.) activate the checkbox 'close' 6.) click on button 'save' 7.) Check that your Invoice has been modified. The status is now "Closed on ..." and the checkbox is now 'Reopen' 8.) Click on the link to the vendor to go the vendors page 9.) click on button 'receive shipment' 10.) Check that the closed invoice is displayed in the list above the section to receive a shipment where you can enter the invoice number. Imagine now you have more than 20 closed invoices from this vendor. The section to receive a shipment is then at the bottom of the page and you have to scroll down to enter an invoice number every time you get a new invoice from this vendor.
For a library using Koha for multiple years an many invoices this is a big issue. Updating severity.
Is this really a regression?
Created attachment 174818 [details] [review] Bug 38343: Do not show closed invoices by default when receiving Filter out closed invoices by default when receiving. Test plan: 1.) go to acquisition module and search for a vendor 2.) click on button 'receive shipment' 3.) enter an invoice number and click 'next' 4.) click on button 'finish receiving' 5.) activate the checkbox 'close' 6.) click on button 'save' 7.) Check that your Invoice has been modified. The status is now "Closed on ..." and the checkbox is now 'Reopen' 8.) Click on the link to the vendor to go the vendors page 9.) click on button 'receive shipment' => The closed invoice is no longer displayed
I am not sure this is a regression, can you confirm? Also, can you test and confirm that this patch is what you want? I think there is a problem: if all invoices are closed we won't see the filters on the left and be able to select the new checkbox.
(In reply to Jonathan Druart from comment #4) > Created attachment 174818 [details] [review] [review] > Bug 38343: Do not show closed invoices by default when receiving > > Filter out closed invoices by default when receiving. > > Test plan: > 1.) go to acquisition module and search for a vendor > 2.) click on button 'receive shipment' > 3.) enter an invoice number and click 'next' > 4.) click on button 'finish receiving' > 5.) activate the checkbox 'close' > 6.) click on button 'save' > 7.) Check that your Invoice has been modified. The status is now "Closed on > ..." and the checkbox is now 'Reopen' > 8.) Click on the link to the vendor to go the vendors page > 9.) click on button 'receive shipment' > => The closed invoice is no longer displayed 10.) Note the new "Include closed invoices" checkbox in the filters on the left of the screen, check it, filter => The closed invoice is now displayed.
Created attachment 174820 [details] [review] Bug 38343: Do not show closed invoices by default when receiving Filter out closed invoices by default when receiving. Test plan: 1.) go to acquisition module and search for a vendor 2.) click on button 'receive shipment' 3.) enter an invoice number and click 'next' 4.) click on button 'finish receiving' 5.) activate the checkbox 'close' 6.) click on button 'save' 7.) Check that your Invoice has been modified. The status is now "Closed on ..." and the checkbox is now 'Reopen' 8.) Click on the link to the vendor to go the vendors page 9.) click on button 'receive shipment' => The closed invoice is no longer displayed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu>
I am not sure if this is a regression, but the patch works, so I signed off :-)
*** Bug 37475 has been marked as a duplicate of this bug. ***
I am pretty sure it worked like that in the beginning and it's documented like that in our internal documentation, but it's already not the case in 22.11.20. It could have been changed as part of a bug fix, then the version might not play that much of a role, but it's hard to tell without digging deeper. As you can't receive for a closed invoice without reopening it first, the change does make a lot of sense anyway. Also thelist doesn't get polluted into "unusefulness" and slow performance.
I looked into a client's environment who uses acquisitions a lot and are in 23.05 and all invoices are displayed. I do think it's polluting (they have 912 invoices for one particular vendor!), but I worry they will think the invoices are lost if they just suddenly disappear. Could we just add something like for the baskets where the closed baskets are hidden, but there is a link to show closed baskets?
(In reply to Caroline Cyr La Rose from comment #11) > I looked into a client's environment who uses acquisitions a lot and are in > 23.05 and all invoices are displayed. I do think it's polluting (they have > 912 invoices for one particular vendor!), but I worry they will think the > invoices are lost if they just suddenly disappear. Could we just add > something like for the baskets where the closed baskets are hidden, but > there is a link to show closed baskets? I had that thought too - I was actually about to upload a QA follow-up to show the filters (and thus, the "Include closed invoices" checkbox) even if there are no results. Do you think that will be clear enough, or is just having a checkbox at the bottom of the filters box too subtle?
(In reply to Emily Lamancusa (emlam) from comment #12) > (In reply to Caroline Cyr La Rose from comment #11) > > I looked into a client's environment who uses acquisitions a lot and are in > > 23.05 and all invoices are displayed. I do think it's polluting (they have > > 912 invoices for one particular vendor!), but I worry they will think the > > invoices are lost if they just suddenly disappear. Could we just add > > something like for the baskets where the closed baskets are hidden, but > > there is a link to show closed baskets? > > I had that thought too - I was actually about to upload a QA follow-up to > show the filters (and thus, the "Include closed invoices" checkbox) even if > there are no results. Do you think that will be clear enough, or is just > having a checkbox at the bottom of the filters box too subtle? I think that would be a nice enhancement Emily. And we can add a text to the release notes to make sure that closed invoices can still be found on the vendors page or can be searched in the acquistion module (koha/acqui/invoices.pl)
Created attachment 174844 [details] [review] Bug 38343: (QA follow-up) Always show filters If a library is expecting to have open invoices and does not, they may want to check the closed invoices. The option to include closed invoices should be visible in that case - otherwise, it's several extra clicks to back out into the Acquisitions module and search the invoices.
Created attachment 174845 [details] [review] Bug 38343: (QA follow-up) Improve tests and tidy
Created attachment 174846 [details] [review] Bug 38343: Do not show closed invoices by default when receiving Filter out closed invoices by default when receiving. Test plan: 1.) go to acquisition module and search for a vendor 2.) click on button 'receive shipment' 3.) enter an invoice number and click 'next' 4.) click on button 'finish receiving' 5.) activate the checkbox 'close' 6.) click on button 'save' 7.) Check that your Invoice has been modified. The status is now "Closed on ..." and the checkbox is now 'Reopen' 8.) Click on the link to the vendor to go the vendors page 9.) click on button 'receive shipment' => The closed invoice is no longer displayed Signed-off-by: Michaela Sieber <michaela.sieber@kit.edu> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 174847 [details] [review] Bug 38343: (QA follow-up) Always show filters If a library is expecting to have open invoices and does not, they may want to check the closed invoices. The option to include closed invoices should be visible in that case - otherwise, it's several extra clicks to back out into the Acquisitions module and search the invoices. Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Created attachment 174848 [details] [review] Bug 38343: (QA follow-up) Improve tests and tidy Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Maybe I can open another bug for this and it can be done separately, but could we show something like "No open invoices" and a link "Show all invoices" like for the baskets? I feel like that is consistent with what we do elsewhere and it's clear where to get your invoices that you used to see https://snipboard.io/q2Jbsp.jpg
I agree with Caroline. There are situations where reopening an invoice for adjustments might be necessary. For example, to process replacements for damaged items or missing copies in the order. In these cases, it seems logical to go directly to the receiving page, select the previous "closed" invoice and make the necessary adjustments. Perhaps a 'Show All Invoices' link could be added to display hidden closed invoices when required. This would reduce unnecessary steps.