Attachment 174904 Details for Bug 38512 – Bug 38512: Only show status of recall when it is item_level

[patch] Bug 38512: Only show status of recall when it is item_level

Bug-38512-Only-show-status-of-recall-when-it-is-it.patch (text/plain), 2.67 KB, created by Lucas Gass (lukeg) on 2024-11-21 22:40:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2024-11-21 22:40:47 UTC

Size: 2.67 KB

patch

obsolete

>From 3ae3f1d96a6ec80b9f78eacead6e0416adcc1219 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Thu, 21 Nov 2024 22:37:06 +0000
>Subject: [PATCH] Bug 38512: Only show status of recall when it is item_level
>
>To test:
>1. Turn on  UseRecalls
>2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count))
>3. Check something out to a patron, choose a record with multiple items on it
>4. With another patron recall the item from the OPAC
>5. Choose "Recall next available item"
>6. Now go back to the item table and see that all items on the bib say something like: "recalled by koha (42) on 11/21/2024".
>7. APPLY PATCH
>8. Do steps 3 - 6 again and now the items should correcylt show as available.
>9. Place a recall again but choose 'Recall a specific item'.
>10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024"
>11. Turn off UseRecalls, make sure the table still loads properly.
>---
> .../includes/html_helpers/tables/items/catalogue_detail.inc   | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>index 9fa81b87f7..d53970fe49 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/html_helpers/tables/items/catalogue_detail.inc
>@@ -547,7 +547,7 @@
>                     }
> 
>                     [% IF Koha.Preference('UseRecalls') %]
>-                        if ( row.recall ) {
>+                        if ( row.recall && row.recall.item_level ) {
>                             if ( row.recall.waiting_date ) {
>                                 nodes += '<span>%s</span>'.format(_("Waiting at %s since %s").format(escape_str(row.recall.pickup_library_id.str), $date(row.recall.waiting_date)));
>                             } else {
>@@ -560,7 +560,7 @@
>                         }
>                     [% END %]
> 
>-                    if ( ! ( row.not_for_loan_status || item_types_notforloan.get(row.item_type_id) || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged_status || row.transfer || row.first_hold || row.recall ) ) {
>+                    if ( ! ( row.not_for_loan_status || item_types_notforloan.get(row.item_type_id) || row.checked_out_date || row.lost_status || row.withdrawn || row.damaged_status || row.transfer || row.first_hold || ( row.recall && row.recall.item_level )  ) ) {
>                         nodes += ' <span>%s</span>'.format(_("Available"))
>                     }
> 
>-- 
>2.39.2

Actions: View | Diff | Splinter Review

Attachments on bug 38512: 174904 | 175057 | 175068 | 175571