To recreate: 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "recalled by koha (42) on 11/21/2024" That seems incorrect, the items should still show as 'Available'.
Created attachment 174904 [details] [review] Bug 38512: Only show status of recall when it is item_level To test: 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "recalled by koha (42) on 11/21/2024". 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correcylt show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly.
With this patch, If I check out all items on the record and then place a recall on the next available item there is no indication anywhere on the staff detail page that there is a 'next available' recall. I think there should be some indication of that on the record. But is the status column ( item row ) the place to do it?
(In reply to Lucas Gass (lukeg) from comment #2) > With this patch, If I check out all items on the record and then place a > recall on the next available item there is no indication anywhere on the > staff detail page that there is a 'next available' recall. > > I think there should be some indication of that on the record. But is the > status column ( item row ) the place to do it? If I compare to holds, when all items are checked out and I make a bib level hold, there is no indication in the status column ( item row ) that there is a hold. So, I think this patch is correct as is.
Created attachment 175057 [details] [review] Bug 38512: Fix display of recalls in items table 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "Recalled by koha (42) on 11/21/2024" 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correctly show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly.
Note: There as also a problem with the display of the holding library name, I fixed that here.
Created attachment 175068 [details] [review] Bug 38512: Fix display of recalls in items table 1. Turn on UseRecalls 2. Set circ rules to allow for recalls ( Recalls allowed(total) and Recalls allowed(count)) 3. Check something out to a patron, choose a record with multiple items on it 4. With another patron recall the item from the OPAC 5. Choose "Recall next available item" 6. Now go back to the item table and see that all items on the bib say something like: "Recalled by koha (42) on 11/21/2024" 7. APPLY PATCH 8. Do steps 3 - 6 again and now the items should correctly show as available. 9. Place a recall again but choose 'Recall a specific item'. 10. Look at the table again, it should accuretly show the recall in the status column. "recalled by koha (42) on 11/21/2024" 11. Turn off UseRecalls, make sure the table still loads properly. Signed-off-by: Emmi Takkinen <emmi.takkinen@koha-suomi.fi>