Attachment 175032 Details for Bug 37992 – Bug 37992: Make memberresultst thead sticky

[patch] Bug 37992: Make memberresultst thead sticky

Bug-37992-Make-memberresultst-thead-sticky.patch (text/plain), 1.53 KB, created by David Nind on 2024-11-29 17:19:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2024-11-29 17:19:12 UTC

Size: 1.53 KB

patch

obsolete

>From 8192238f904ff5ed972781133ef1728655087d64 Mon Sep 17 00:00:00 2001
>From: Lucas Gass <lucas@bywatersolutions.com>
>Date: Wed, 20 Nov 2024 17:11:45 +0000
>Subject: [PATCH] Bug 37992: Make memberresultst thead sticky
>
>1. Run empty patron search
>2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected.
>3. The table header (thead) with filters for each column is not sticky. This is a regression.
>(It was sticky in 23.11, but not anymore in 24.05 and main)
>4. APPLY PATCH and regenerate CSS.
>5. The thead should again be sticky.
>6. Test in at least Chrome and Firefox.
>
>Notes:
>-Setting top to 40px, which covers the height of the #searchheader
>-To avoid border styles not working with the sticky element I am unsetting border-collapse.
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>index b43fe29c30..02226e15b0 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>+++ b/koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss
>@@ -1929,6 +1929,14 @@ li {
>     padding: 20px;
> }
> 
>+#memberresultst {
>+    border-collapse: unset;
>+    thead {
>+        position: sticky;
>+        top: 40px;
>+    }
>+}
>+
> #searchresults {
>     background-color: #FFFFFF;
>     margin-bottom: 1rem;
>-- 
>2.39.5

Actions: View | Diff | Splinter Review

Attachments on bug 37992: 174851 | 175032 | 175375