1. Run empty patron search 2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected. 3. The table header (thead) with filters for each column is not sticky. This is a regression. (It was sticky in 23.11, but not anymore in 24.05 and main)
Created attachment 174851 [details] [review] Bug 37992: Make memberresultst thead sticky 1. Run empty patron search 2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected. 3. The table header (thead) with filters for each column is not sticky. This is a regression. (It was sticky in 23.11, but not anymore in 24.05 and main) 4. APPLY PATCH and regenerate CSS. 5. The thead should again be sticky. 6. Test in at least Chrome and Firefox. Notes: -Setting top to 40px, which covers the height of the #searchheader -To avoid border styles not working with the sticky element I am unsetting border-collapse.
Created attachment 175032 [details] [review] Bug 37992: Make memberresultst thead sticky 1. Run empty patron search 2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected. 3. The table header (thead) with filters for each column is not sticky. This is a regression. (It was sticky in 23.11, but not anymore in 24.05 and main) 4. APPLY PATCH and regenerate CSS. 5. The thead should again be sticky. 6. Test in at least Chrome and Firefox. Notes: -Setting top to 40px, which covers the height of the #searchheader -To avoid border styles not working with the sticky element I am unsetting border-collapse. Signed-off-by: David Nind <david@davidnind.com>
Created attachment 175375 [details] [review] Bug 37992: Make memberresultst thead sticky 1. Run empty patron search 2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected. 3. The table header (thead) with filters for each column is not sticky. This is a regression. (It was sticky in 23.11, but not anymore in 24.05 and main) 4. APPLY PATCH and regenerate CSS. 5. The thead should again be sticky. 6. Test in at least Chrome and Firefox. Notes: -Setting top to 40px, which covers the height of the #searchheader -To avoid border styles not working with the sticky element I am unsetting border-collapse. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
This works in both Chrome and Firefox and the code makes sense. Passing QA I did notice that on a high resolution monitor like 4k, or if the browser is zoomed at a certain level a small gap can appear between the two sticky headers, where you can see the table scrolling behind, but it's not enough of an issue to be a blocker.
Pushed for 25.05! Well done everyone, thank you!
Nice work everyone! Pushed to 24.11.x for 24.11.01
not backporting to 24.05.x unless requested - dependency not in 24.05