Bug 37992 - Patron search results: table header with column filters isn't sticky anymore
Summary: Patron search results: table header with column filters isn't sticky anymore
Status: Pushed to stable
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal
Assignee: Lucas Gass (lukeg)
QA Contact: Brendan Lawlor
URL:
Keywords:
Depends on: 36694
Blocks:
  Show dependency treegraph
 
Reported: 2024-09-23 19:12 UTC by Victor Grousset/tuxayo
Modified: 2025-02-20 20:49 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Trivial patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
This fixes the sticky header for patron search results - it now includes the column headings and filters. (This restores the behavour to what it was in Koha 23.11.)
Version(s) released in:
25.05.00,24.11.02
Circulation function:


Attachments
Bug 37992: Make memberresultst thead sticky (1.48 KB, patch)
2024-11-20 17:15 UTC, Lucas Gass (lukeg)
Details | Diff | Splinter Review
Bug 37992: Make memberresultst thead sticky (1.53 KB, patch)
2024-11-29 17:19 UTC, David Nind
Details | Diff | Splinter Review
Bug 37992: Make memberresultst thead sticky (1.58 KB, patch)
2024-12-11 16:29 UTC, Brendan Lawlor
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Victor Grousset/tuxayo 2024-09-23 19:12:53 UTC
1. Run empty patron search
2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected.
3. The table header (thead) with filters for each column is not sticky. This is a regression.
(It was sticky in 23.11, but not anymore in 24.05 and main)
Comment 1 Lucas Gass (lukeg) 2024-11-20 17:15:13 UTC Comment hidden (obsolete)
Comment 2 David Nind 2024-11-29 17:19:12 UTC
Created attachment 175032 [details] [review]
Bug 37992: Make memberresultst thead sticky

1. Run empty patron search
2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected.
3. The table header (thead) with filters for each column is not sticky. This is a regression.
(It was sticky in 23.11, but not anymore in 24.05 and main)
4. APPLY PATCH and regenerate CSS.
5. The thead should again be sticky.
6. Test in at least Chrome and Firefox.

Notes:
-Setting top to 40px, which covers the height of the #searchheader
-To avoid border styles not working with the sticky element I am unsetting border-collapse.

Signed-off-by: David Nind <david@davidnind.com>
Comment 3 Brendan Lawlor 2024-12-11 16:29:29 UTC
Created attachment 175375 [details] [review]
Bug 37992: Make memberresultst thead sticky

1. Run empty patron search
2. Assuming there are enough results, when scrolling down the #searchheader with "select all" button would get hidden. But no, it's sticky so it follows you and stays visible. This is expected.
3. The table header (thead) with filters for each column is not sticky. This is a regression.
(It was sticky in 23.11, but not anymore in 24.05 and main)
4. APPLY PATCH and regenerate CSS.
5. The thead should again be sticky.
6. Test in at least Chrome and Firefox.

Notes:
-Setting top to 40px, which covers the height of the #searchheader
-To avoid border styles not working with the sticky element I am unsetting border-collapse.

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org>
Comment 4 Brendan Lawlor 2024-12-11 17:20:35 UTC
This works in both Chrome and Firefox and the code makes sense. Passing QA

I did notice that on a high resolution monitor like 4k, or if the browser is zoomed at a certain level a small gap can appear between the two sticky headers, where you can see the table scrolling behind, but it's not enough of an issue to be a blocker.
Comment 5 Katrin Fischer 2024-12-23 08:37:59 UTC
Pushed for 25.05!

Well done everyone, thank you!
Comment 6 Paul Derscheid 2025-02-03 19:08:57 UTC
Nice work everyone!

Pushed to 24.11.x for 24.11.01
Comment 7 Alex Buckley 2025-02-20 20:49:31 UTC
not backporting to 24.05.x unless requested - dependency not in 24.05